Re: [GIT]: Networking

David Miller
2009-01-06T04:16:37Z

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Mon, 5 Jan 2009 18:42:19 -0800 (PST)

> On Mon, 5 Jan 2009, David Miller wrote:
> >
> > Jaswinder Singh (1):
> > firmware: convert acenic driver to request_firmware()
>
> Grr. But the old acenic_firmware.h file is left around. Which explains
> this:
>
> > 63 files changed, 11470 insertions(+), 1910 deletions(-)
>
> Ugh. That looks absolutely horrible.
>
> I pulled, but please take a look at your own diffstats and then ask
> yourself if things really look like they should look. Because if you had
> done that, you'd have noticed this.

Sorry, I know how this happened even.

As an aside, is there a way to make git-am and other stuff using the
git patch applying engine to take patches liberally like 'patch'
would?

The default is extremely strict, which makes me check things out by
hand. That's good, but as I add the change by hand after verifying
it's sanity I often make mistakes that result in things like the above
missed delete, so if I could ask git to be non-strict it would help me
out a lot.

This doesn't excuse me from looking for bogons at my diffstats of
course :)