Re: [GIT]: Networking

Sam Ravnborg
2009-01-06T05:50:28Z

On Tue, Jan 06, 2009 at 10:44:11AM +0530, Jaswinder Singh Rajput wrote:
> On Tue, Jan 6, 2009 at 10:19 AM, David Miller <davem@davemloft.net> wrote:
> >
> > I had 4 firmware patches to apply, each one had to add entries
> > to the same file.
> >
> > The first patch had to be skipped.
> >
>
> In firmware we maintain WHENCE, so every time we add new firmware we
> also update WHENCE.
>
> We are facing problems while we prepare patch for firmware as we add
> new stuff at the end.
> As per David Woodhouse suggestion, I arranged WHENCE to alphabetical
> order by driver name to avoid conflicts.
>
> I also send patch on 21 Dec 2008 with ack of David Woodhouse to linus
> and waiting from his side.
>
> [PATCH] firmware: Arrange WHENCE in alphabetical order to avoid conflicts
>
> I think this will resolve very soon, once we update WHENCE in
> alphabetical order, If you better suggestions, please let me know.

We should avoid a central file and push this information
out to the Kconfig files that are at the driver site.

Then we can postprocess autoconf.h to get the filenames etc.

And IMO it is wrong to stroe the firmware files far away
from the driver where they belong.

Sorting WHENCE is a good approach under the current ways
of doing it. But the current ways of doing it looks plain wrong to me.

Sam