Re: [GIT]: Networking

Ingo Molnar
2008-10-17T13:36:29Z

* Patrick McHardy <kaber@trash.net> wrote:

> Pablo Neira Ayuso wrote:
>> Ingo Molnar wrote:
>>> * Patrick McHardy <kaber@trash.net> wrote:
>>>
>>>>> net/netfilter/nf_conntrack_netlink.c:819: warning: ‘enum
>>>>> nf_nat_manip_type’ declared inside parameter list
>>>>> net/netfilter/nf_conntrack_netlink.c:819: warning: its scope is
>>>>> only this definition or declaration, which is probably not what
>>>>> you want
>>>>> net/netfilter/nf_conntrack_netlink.c:818: error: parameter 2
>>>>> (‘manip’) has incomplete type
>>>> Thanks Ingo. I just sent this patch to Benjamin Herrenschmidt
>>>> for testing.
>>>
>>> build still fails with the attached config.
>>
>> This should fix it. I have slightly tested it here with your config.
>>
>
> Applied, thanks Pablo.
>
> I'll look into cleaning up those conditional includes. Its getting
> more and more complicated to even build-test all the combinations.

yeah - very often build errors in rare .config scenarios are canaries
for structural problems.

(We had such a situation in the x86 code recently: we had those quirky
x86 subarchitectures, and they were a constant source of build errors
that no real user actually cared about - because there were no active
users left. We modularized them into the main platform and we havent had
a single build bug in them in the last couple of months.)

Ingo