Re: [GIT] Networking

Michał Mirosław
2013-05-02T17:55:18Z

2013/5/2 David Miller <davem@davemloft.net>:
> From: Dan Williams <dcbw@redhat.com>
> Date: Thu, 02 May 2013 11:34:27 -0500
>
>> On Wed, 2013-05-01 at 18:28 -0700, Linus Torvalds wrote:
>>> On Wed, May 1, 2013 at 1:47 PM, David Miller <davem@davemloft.net> wrote:
>>> >
>>> > Highlights (1721 non-merge commits, this has to be a record of some
>>> > sort):
>>>
>>> Lowlight: it completely breaks my machine with r8169 ethernet. In the
>>> networkmanager applet, it claims no cable connection, which is a bit
>>> odd, because (a) it works with an older kernel and (b) the kernel
>>> messages actually say
>>>
>>> r8169 0000:01:00.0 eth0: link up
>>
>> NM calls ETHTOOL_GLINK and if that returns success, NM expects the
>> driver to support carrier detection. NM then listens to netlink for
>> device flags changes, and uses IFF_LOWER_UP to determine carrier on/off
>> state. NM does not use NETIF_F_VLAN_CHALLENGED or any of the other
>> ETHTOOL_GFEATURES flags yet, but will in the future.
>>
>> Is the link status accurately reflected by /sys/class/net/eth0/carrier ?
> Something cares about the .../eth0/flags value because with the bit
> ordering different for bits 10 and above things break.

Are you sure it's "flags"? /sys/class/net/*/features were removed some
time ago, and flags don't depend on NETIF_F_*.

Best Regards,
Michał Mirosław