Re: [GIT] Networking

Paul Gortmaker
2015-06-25T16:25:01Z

On Wed, Jun 24, 2015 at 7:38 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:

[...]

>
> I'm getting *real* tired of that BUG_ON() shit. I realize that
> infiniband is a niche market, and those "commercial grade" niche
> markets are more-than-used-to crap code and horrible hacks, but this
> is still the kernel. We don't add random machine-killing debug checks
> when it is *so* simple to just do
>
> if (WARN_ON_ONCE(..))
> return -EINVAL;
>
> instead.
>
> Killing the machine for idiotic things like that is truly offensive,
> and truly horrible horrible code. Why do I keep on having to tell
> people off for doing these things? Why do people keep thinking that
> debugging-by-killing-the-machine is a good idea?

Ingo figured this was an educational battle that we'd never win.

https://lkml.org/lkml/2014/5/21/490

I tend to agree, as unfortunate as that is.

Paul.
--

>
> Either that BUG_ON() cannot possibly happen, in which case it should
> damn well not exist in the first place. Or it's a valuable debug aid,
> in which case it should damn well not be a BUG_ON. You can't have it
> both ways.
>
> The next pointless BUG_ON() I see, I will start getting _really_
> unpleasant about.
>
> Doug, get rid of those things asap.
>
> Linus
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html