Re: [GIT] Networking

Linus Torvalds
2013-05-02T04:37:42Z

On Wed, May 1, 2013 at 6:28 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> Lowlight: it completely breaks my machine with r8169 ethernet. In the
> networkmanager applet, it claims no cable connection, which is a bit
> odd, because (a) it works with an older kernel and (b) the kernel
> messages actually say
>
> r8169 0000:01:00.0 eth0: link up
>
> but nothing actually works.
>
> r8169 Gigabit Ethernet driver 2.3LK-NAPI loaded
> r8169 0000:01:00.0 eth0: RTL8168d/8111d at 0xffffc90010ece000,
> e0:cb:4e:95:1a:d7, XID 083000c0 IRQ 53
> r8169 0000:01:00.0 eth0: jumbo features [frames: 9200 bytes, tx
> checksumming: ko]
>
> Any ideas?

Hmm. I bisected it.

And my machine is broken by commit 8ad227ff89a7 ("net: vlan: add
802.1ad support"). I booted several times just to make sure, and it's
consistent. The previous commit (86a9bad3ab6b) works fine, and
8ad227ff89a7 is broken.

I don't see what could be broken in that commit, and I'd *like* to
just revert it on top of current -git, but that causes problems
("error: ‘NETIF_F_HW_VLAN_STAG_TX_BIT’ undeclared"), so I can't just
do a straight revert to double-check with the current tree state. But
the bisection was very straightforward, and as mentioned, I checked
that boundary several times just because it looked so odd.

Maybe somebody who knows the code better just goes "Duh!". Anybody?

Linus