Re: [GIT]: Networking

David Miller
2008-05-09T04:25:18Z

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Thu, 8 May 2008 18:51:08 -0700 (PDT)

> David, you need to stop sending patches like this after -rc1.
>
> This is too big. I'm taking it, but there's something wrong in this. Your
> merges after -rc1 have generally been way too large, and I need to shut
> you down if this gets to be a big pattern.
>
> It's one thing taking a totally new driver (that couldn't have worked
> before and cannot be a regression) or adding new PCI ID's. It's a totally
> different thing to take 800 lines of code to an old driver that people
> depend on. These things need to happen during the merge window, and just
> because they are drivers doesn't mean that they can just do anythign they
> want.

I saw that e1000e commit from Jeff's tree and was about to push
back on him. But I decided not to.

I will next time if it's such a big deal, but frankly I thought this
one was OK. It's stupid to make people wait until 2.6.27 to be able
to use the e1000e cards with the new PHY type. It causes some hw bug
workaround to need to be added to the e1000e driver, and that's where
the bulk of that 800 line change is from.

Distributions are going to add that e1000e PHY support patch anyways,
regardless of what we do, and isn't that one of the reasons we were
talking about more aggressively merging new drivers?

Who the heck are we kidding if we don't put changes like that into the
tree when pretty much every distribution will? Yes, even after rc1.