From: "H. Peter Anvin" <hpa@zytor.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>, Roland Dreier <rdreier@cisco.com>,
Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Thomas Gleixner <tglx@linutronix.de>,
David Howells <dhowells@redhat.com>
Subject: Re: [announce] new tree: "fix all build warnings, on all configs"
Date: Mon, 20 Oct 2008 09:49:24 -0700 [thread overview]
Message-ID: <48FCB694.40901@zytor.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0810200933470.3518@nehalem.linux-foundation.org>
Linus Torvalds wrote:
>
> The old code was correct. Your code is shit. And you didn't fix
> _anything_.
>
>> case 5:
>> *(int *)to = *(int *)from;
>> - *((short *)to + 3) = *((short *)from + 3);
>> + *((char *)(to + 3)) = *((char *)(from + 3));
>> return to;
>
> Are you just making changes by randomly inserting and deleting characters
> until you don't see warnings? Or what?
>
> That thing is supposed to be a 5-byte memcpy. Not a "take a random byte
> from a random location and move it to another random location". That would
> be "randcpy()", not "memcpy()".
>
That is not a 5-byte memcopy. In *either* version!
In the "before" case, it copies bytes 0, 1, 2, 3, 6 and 7.
In the "after" case, it copies bytes 0, 1 and 2.
Presumably it *should* be:
*((char *)to + 4) = *((char *)from + 4);
-hpa
next prev parent reply other threads:[~2008-10-20 16:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 17:11 [announce] new tree: "fix all build warnings, on all configs" Ingo Molnar
2008-10-17 17:59 ` Roland Dreier
2008-10-17 18:05 ` Ingo Molnar
2008-10-17 18:47 ` Roland Dreier
2008-10-17 19:12 ` Ingo Molnar
2008-10-17 19:36 ` Roland Dreier
2008-10-18 8:22 ` Ingo Molnar
2008-10-20 16:37 ` Linus Torvalds
2008-10-20 16:49 ` H. Peter Anvin [this message]
2008-10-20 16:57 ` Linus Torvalds
2008-10-20 19:21 ` Ingo Molnar
2008-10-21 6:41 ` Jörn Engel
2008-10-22 9:47 ` Ingo Molnar
2008-10-22 10:10 ` Jörn Engel
2008-10-18 7:43 ` Andi Kleen
2008-10-21 10:30 ` [announce] new tree: "fix all build warnings, on all configs" II Andi Kleen
2008-10-21 11:17 ` [announce] new tree: "fix all build warnings, on all configs" Ingo Molnar
2008-10-21 12:07 ` Andi Kleen
2008-10-21 19:39 ` Rafael J. Wysocki
2008-10-21 19:37 ` Rafael J. Wysocki
2008-10-22 4:11 ` Len Brown
2008-10-22 12:23 ` [PATCH] ACPI suspend: Fix CONFIG_ACPI_SLEEP dependence and some compilation warnings (was: Re: [announce] new tree: "fix all build warnings, on all configs") Rafael J. Wysocki
2008-10-22 18:58 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FCB694.40901@zytor.com \
--to=hpa@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rdreier@cisco.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox