public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Matt Helsley <matthltc@us.ibm.com>,
	Cedric Le Goater <clg@fr.ibm.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux Containers <containers@lists.linux-foundation.org>
Subject: [PATCH 3/4] freezer_cg: use thaw_process() in unfreeze_cgroup()
Date: Tue, 21 Oct 2008 08:51:16 +0800	[thread overview]
Message-ID: <48FD2784.30906@cn.fujitsu.com> (raw)
In-Reply-To: <48FD273F.3040505@cn.fujitsu.com>

Don't duplicate the implementation of thaw_process().

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
 kernel/cgroup_freezer.c |   15 ++++-----------
 1 files changed, 4 insertions(+), 11 deletions(-)

diff --git a/kernel/cgroup_freezer.c b/kernel/cgroup_freezer.c
index 6fadafe..3ea57e4 100644
--- a/kernel/cgroup_freezer.c
+++ b/kernel/cgroup_freezer.c
@@ -275,25 +275,18 @@ static int try_to_freeze_cgroup(struct cgroup *cgroup, struct freezer *freezer)
 	return num_cant_freeze_now ? -EBUSY : 0;
 }
 
-static int unfreeze_cgroup(struct cgroup *cgroup, struct freezer *freezer)
+static void unfreeze_cgroup(struct cgroup *cgroup, struct freezer *freezer)
 {
 	struct cgroup_iter it;
 	struct task_struct *task;
 
 	cgroup_iter_start(cgroup, &it);
 	while ((task = cgroup_iter_next(cgroup, &it))) {
-		int do_wake;
-
-		task_lock(task);
-		do_wake = __thaw_process(task);
-		task_unlock(task);
-		if (do_wake)
-			wake_up_process(task);
+		thaw_process(task);
 	}
 	cgroup_iter_end(cgroup, &it);
-	freezer->state = CGROUP_THAWED;
 
-	return 0;
+	freezer->state = CGROUP_THAWED;
 }
 
 static int freezer_change_state(struct cgroup *cgroup,
@@ -320,7 +313,7 @@ static int freezer_change_state(struct cgroup *cgroup,
 		}
 		/* state == FREEZING and goal_state == THAWED, so unfreeze */
 	case CGROUP_FROZEN:
-		retval = unfreeze_cgroup(cgroup, freezer);
+		unfreeze_cgroup(cgroup, freezer);
 		break;
 	default:
 		break;
-- 
1.5.4.rc3

  reply	other threads:[~2008-10-21  0:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-21  0:48 [PATCH 1/4] freezer_cg: fix improper BUG_ON() causing oops Li Zefan
2008-10-21  0:50 ` [PATCH 2/4] freezer_cg: remove redundant check in freezer_can_attach() Li Zefan
2008-10-21  0:51   ` Li Zefan [this message]
2008-10-21  0:52     ` [PATCH 4/4] freezer_cg: simplify freezer_change_state() Li Zefan
2008-10-21  9:53       ` Cedric Le Goater
2008-10-21 21:45       ` Matt Helsley
2008-10-21  7:16     ` [PATCH 3/4] freezer_cg: use thaw_process() in unfreeze_cgroup() Cedric Le Goater
2008-10-21  8:40       ` Li Zefan
2008-10-21 20:58       ` Andrew Morton
2008-10-22  7:37         ` Cedric Le Goater
2008-10-21 21:44     ` Matt Helsley
2008-10-21  7:32   ` [PATCH 2/4] freezer_cg: remove redundant check in freezer_can_attach() Cedric Le Goater
2008-10-21  9:29     ` Li Zefan
2008-10-21  9:47       ` Cedric Le Goater
2008-10-21 21:40   ` Matt Helsley
2008-10-21  7:16 ` [PATCH 1/4] freezer_cg: fix improper BUG_ON() causing oops Cedric Le Goater
2008-10-21 21:39 ` Matt Helsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48FD2784.30906@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=clg@fr.ibm.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthltc@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox