* Re: [PATCH] atmel_lcdfb: unsigned irq_base cannot be negative
[not found] <48FD4F7E.6010708@gmail.com>
@ 2008-10-21 8:46 ` Nicolas Ferre
0 siblings, 0 replies; only message in thread
From: Nicolas Ferre @ 2008-10-21 8:46 UTC (permalink / raw)
To: roel kluin; +Cc: linux-fbdev-devel, Linux Kernel list
Hi,
roel kluin :
> unsigned irq_base cannot be negative
Indeed. Thanks for taking this point !
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
> index f8d0a57..f93f57a 100644
> --- a/drivers/video/atmel_lcdfb.c
> +++ b/drivers/video/atmel_lcdfb.c
> @@ -857,12 +857,12 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
> goto stop_clk;
> }
>
> - sinfo->irq_base = platform_get_irq(pdev, 0);
> - if (sinfo->irq_base < 0) {
> + ret = platform_get_irq(pdev, 0);
> + if (ret < 0) {
> dev_err(dev, "unable to get irq\n");
> - ret = sinfo->irq_base;
> goto stop_clk;
> }
> + sinfo->irq_base = ret;
I prefer changing the definition of irq_base to plain int.
So the patch becomes obvious:
- unsigned long irq_base;
+ int irq_base;
What do you think of this ?
I repost a patch addressing this issue.
Regards,
--
Nicolas Ferre
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-10-21 8:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <48FD4F7E.6010708@gmail.com>
2008-10-21 8:46 ` [PATCH] atmel_lcdfb: unsigned irq_base cannot be negative Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox