* [PATCH] fork.c: fix a problem of code style
@ 2008-10-21 14:16 Jianjun Kong
2008-10-21 16:00 ` Christoph Lameter
2008-10-21 16:32 ` David Newall
0 siblings, 2 replies; 4+ messages in thread
From: Jianjun Kong @ 2008-10-21 14:16 UTC (permalink / raw)
To: cl; +Cc: Linux-Kernel-Mailing-List
fix a problem of code style
Signed-off-by: Jianjun Kong <jianjun@zeuux.org>
---
kernel/fork.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/fork.c b/kernel/fork.c
index 30de644..b6e5a94 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -187,7 +187,7 @@ void __init fork_init(unsigned long mempages)
/*
* we need to allow at least 20 threads to boot a system
*/
- if(max_threads < 20)
+ if (max_threads < 20)
max_threads = 20;
init_task.signal->rlim[RLIMIT_NPROC].rlim_cur = max_threads/2;
--
1.5.2.5
--
Jianjun Kong | Happy Hacking
HomePage: http://kongove.cn
Gtalk: kongjianjun@gmail.com
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fork.c: fix a problem of code style
2008-10-21 14:16 [PATCH] fork.c: fix a problem of code style Jianjun Kong
@ 2008-10-21 16:00 ` Christoph Lameter
2008-10-21 16:32 ` David Newall
1 sibling, 0 replies; 4+ messages in thread
From: Christoph Lameter @ 2008-10-21 16:00 UTC (permalink / raw)
To: Jianjun Kong; +Cc: Linux-Kernel-Mailing-List, Andrew Morton
For what its worth
Reviewed-by: Christoph Lameter <cl@linux-foundation.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fork.c: fix a problem of code style
2008-10-21 14:16 [PATCH] fork.c: fix a problem of code style Jianjun Kong
2008-10-21 16:00 ` Christoph Lameter
@ 2008-10-21 16:32 ` David Newall
2008-10-29 0:28 ` Andrew Morton
1 sibling, 1 reply; 4+ messages in thread
From: David Newall @ 2008-10-21 16:32 UTC (permalink / raw)
To: Jianjun Kong; +Cc: cl, Linux-Kernel-Mailing-List
Jianjun Kong wrote:
> - if(max_threads < 20)
> + if (max_threads < 20)
I thought we didn't bother with trivial style changes like this.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fork.c: fix a problem of code style
2008-10-21 16:32 ` David Newall
@ 2008-10-29 0:28 ` Andrew Morton
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2008-10-29 0:28 UTC (permalink / raw)
To: David Newall; +Cc: jianjun, cl, linux-kernel
On Wed, 22 Oct 2008 03:02:21 +1030
David Newall <davidn@davidnewall.com> wrote:
> Jianjun Kong wrote:
> > - if(max_threads < 20)
> > + if (max_threads < 20)
>
> I thought we didn't bother with trivial style changes like this.
Yes, it's too small:
akpm:/usr/src/25> perl scripts/checkpatch.pl --file kernel/fork.c | grep total
total: 34 errors, 13 warnings, 1689 lines checked
We could merge thousands and thousand of one-line patches like this and
it's all very inefficient.
I'd consider larger patches which cleaned up whole subdirectories.
They're not much fun to maintain but we don't regret these things after
we've done them.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-10-29 0:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-21 14:16 [PATCH] fork.c: fix a problem of code style Jianjun Kong
2008-10-21 16:00 ` Christoph Lameter
2008-10-21 16:32 ` David Newall
2008-10-29 0:28 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox