Re: [PATCH v2] add MODULE_ALIAS to load ipmi_devintf with ipmi_si

[Corey Minyard <minyard@acm.org>]

Yes, this is certainly a good idea.  I'm not 100% sure of the string, 
but it looks reasonable.

Signed-off-by: Corey Minyard <cminyard@mvista.com>

Tim Gardner wrote:
> From 07463c240c3609c1e2fbed45f64acd5fd061ce58 Mon Sep 17 00:00:00 2001
> From: Scott James Remnant <scott@canonical.com>
> Date: Tue, 21 Oct 2008 15:18:36 +0100
> Subject: [PATCH v2] add MODULE_ALIAS to load ipmi_devintf with ipmi_si
>
> The ipmi_devintf module contains the userspace interface for IPMI
> devices, yet will not be loaded automatically with a system
> interface handler driver.
>
> Add a MODULE_ALIAS for the "platform:ipmi_si" MODALIAS exported by
> the ipmi_si driver, so that userspace knows of the recommendation.
>
> Seems like a candidate for stable kernel updates.
>
> Cc: stable@kernel.org
> Signed-off-by: Scott James Remnant <scott@ubuntu.com>
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> ---
>  drivers/char/ipmi/ipmi_devintf.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_devintf.c b/drivers/char/ipmi/ipmi_devintf.c
> index 64e1c16..ecaf369 100644
> --- a/drivers/char/ipmi/ipmi_devintf.c
> +++ b/drivers/char/ipmi/ipmi_devintf.c
> @@ -957,3 +957,4 @@ module_exit(cleanup_ipmi);
>  MODULE_LICENSE("GPL");
>  MODULE_AUTHOR("Corey Minyard <minyard@mvista.com>");
>  MODULE_DESCRIPTION("Linux device interface for the IPMI message handler.");
> +MODULE_ALIAS("platform:ipmi_si");
>