From: "Török Edwin" <edwintorok@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
sandmann@daimi.au.dk, linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH 4/4] Implement semaphore latency tracer
Date: Wed, 22 Oct 2008 18:41:49 +0300 [thread overview]
Message-ID: <48FF49BD.8000608@gmail.com> (raw)
In-Reply-To: <20081022152842.GI23060@elte.hu>
On 2008-10-22 18:28, Ingo Molnar wrote:
> hm, but the most common synchronization primitive are mutexes - and
> those are not covered by your patchset.
>
Indeed. I've seen a patch from Jason Baron to introduce tracepoints for
mutexes, but the conclusion was that the tracepoints
should be in lockstat instead.
And if lockstat is enabled Peter Zijlstra's 'contend with points' patch
seems to do exactly what I want to.
However I think it would be useful to have (a tracepoints based?)
latency tracker, which can be enabled/disabled at runtime,
and which doesn't add any data to the mutex/semaphore structures.
My patchset was a first attempt towards that, but it seems that such use
of tracepoints is not welcome at this time?
Please tell me if I should continue working on this, or if I my patches
are designed totally on the wrong way.
Best regards,
--Edwin
next prev parent reply other threads:[~2008-10-22 15:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-12 13:11 [PATCH 0/4] ftrace: add userspace stacktrace support and semaphore-latency tracer Török Edwin
2008-10-12 13:12 ` Török Edwin
2008-10-12 13:12 ` [PATCH 1/4] Add support for userspace stacktraces in tracing/iter_ctrl Török Edwin
2008-10-12 13:31 ` Frédéric Weisbecker
2008-10-12 13:53 ` Török Edwin
2008-10-13 8:02 ` Frédéric Weisbecker
2008-10-26 4:05 ` Frédéric Weisbecker
2008-10-26 7:03 ` Török Edwin
2008-10-26 15:06 ` Frédéric Weisbecker
2008-10-26 13:15 ` Frank Ch. Eigler
2008-10-26 13:29 ` Peter Zijlstra
2008-10-26 13:38 ` Török Edwin
2008-10-26 13:49 ` Frank Ch. Eigler
2008-10-27 16:03 ` Ingo Molnar
2008-10-27 16:16 ` Török Edwin
2008-10-12 13:12 ` [PATCH 2/4] Identify which executable object the userspace address belongs to Török Edwin
2008-10-12 13:12 ` [PATCH 3/4] add tracepoints in rwsem Török Edwin
2008-10-12 13:12 ` [PATCH 4/4] Implement semaphore latency tracer Török Edwin
2008-10-12 19:13 ` Peter Zijlstra
2008-10-12 20:10 ` Török Edwin
2008-10-22 15:28 ` Ingo Molnar
2008-10-22 15:41 ` Török Edwin [this message]
2008-10-22 15:48 ` Ingo Molnar
2008-10-22 17:22 ` Peter Zijlstra
2008-10-22 17:25 ` Török Edwin
2008-10-12 18:25 ` [PATCH 0/4] ftrace: add userspace stacktrace support and semaphore-latency tracer Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FF49BD.8000608@gmail.com \
--to=edwintorok@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=sandmann@daimi.au.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox