public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: mingo@elte.hu
Cc: hpa@zytor.com, linux-kernel@vger.kernel.org, tglx@linutronix.de,
	yhlu.kernel@gmail.com, macro@linux-mips.org,
	Cyrill Gorcunov <gorcunov@gmail.com>
Subject: [patch 3/3] x86: io-apic - code style cleaning for setup_IO_APIC_irqs
Date: Thu, 04 Sep 2008 22:37:51 +0400	[thread overview]
Message-ID: <48c02b6a.0637560a.15e9.ffffa39d@mx.google.com> (raw)
In-Reply-To: 20080904183748.950151853@gmail.com

[-- Attachment #1: x86-ioapic-simplify-setup_IO_APIC_irqs --]
[-- Type: text/plain, Size: 2189 bytes --]

Use a nested level for 'for' cycle and break long lines.
For apic_print we should countinue using KERNEL_DEBUG if
we have started to.

Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---

Index: linux-2.6.git/arch/x86/kernel/io_apic.c
===================================================================
--- linux-2.6.git.orig/arch/x86/kernel/io_apic.c	2008-09-04 22:08:06.000000000 +0400
+++ linux-2.6.git/arch/x86/kernel/io_apic.c	2008-09-04 22:08:32.000000000 +0400
@@ -1521,32 +1521,35 @@ static void __init setup_IO_APIC_irqs(vo
 	apic_printk(APIC_VERBOSE, KERN_DEBUG "init IO_APIC IRQs\n");
 
 	for (apic = 0; apic < nr_ioapics; apic++) {
-	for (pin = 0; pin < nr_ioapic_registers[apic]; pin++) {
+		for (pin = 0; pin < nr_ioapic_registers[apic]; pin++) {
 
-		idx = find_irq_entry(apic,pin,mp_INT);
-		if (idx == -1) {
-			if (first_notcon) {
-				apic_printk(APIC_VERBOSE, KERN_DEBUG " IO-APIC (apicid-pin) %d-%d", mp_ioapics[apic].mp_apicid, pin);
-				first_notcon = 0;
-			} else
-				apic_printk(APIC_VERBOSE, ", %d-%d", mp_ioapics[apic].mp_apicid, pin);
-			continue;
-		}
-		if (!first_notcon) {
-			apic_printk(APIC_VERBOSE, " not connected.\n");
-			first_notcon = 1;
-		}
+			idx = find_irq_entry(apic, pin, mp_INT);
+			if (idx == -1) {
+				if (first_notcon) {
+					apic_printk(APIC_VERBOSE, KERN_DEBUG
+							" IO-APIC (apicid-pin) %d-%d",
+							mp_ioapics[apic].mp_apicid, pin);
+					first_notcon = 0;
+				} else
+					apic_printk(APIC_VERBOSE, KERN_DEBUG ", %d-%d",
+							mp_ioapics[apic].mp_apicid, pin);
+				continue;
+			}
+			if (!first_notcon) {
+				apic_printk(APIC_VERBOSE, " not connected.\n");
+				first_notcon = 1;
+			}
 
-		irq = pin_2_irq(idx, apic, pin);
+			irq = pin_2_irq(idx, apic, pin);
 #ifdef CONFIG_X86_32
-                if (multi_timer_check(apic, irq))
-                        continue;
+			if (multi_timer_check(apic, irq))
+				continue;
 #endif
-		add_pin_to_irq(irq, apic, pin);
+			add_pin_to_irq(irq, apic, pin);
 
-		setup_IO_APIC_irq(apic, pin, irq,
-				  irq_trigger(idx), irq_polarity(idx));
-	}
+			setup_IO_APIC_irq(apic, pin, irq,
+					irq_trigger(idx), irq_polarity(idx));
+		}
 	}
 
 	if (!first_notcon)

-- 

  parent reply	other threads:[~2008-09-04 18:44 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080904183748.950151853@gmail.com>
2008-09-04 18:37 ` [patch 1/3] x86: io-apic - use ARRAY_SIZE macro Cyrill Gorcunov
2008-09-05  8:02   ` Ingo Molnar
2008-09-04 18:37 ` [patch 2/3] x86: io-apic - declare irq_cfg_lock for SPARSE_IRQ only Cyrill Gorcunov
2008-09-05  8:03   ` Ingo Molnar
2008-09-04 18:37 ` Cyrill Gorcunov [this message]
2008-09-05  8:04   ` [patch 3/3] x86: io-apic - code style cleaning for setup_IO_APIC_irqs Ingo Molnar
2008-09-05 13:49     ` Cyrill Gorcunov
2008-09-05 18:01     ` Cyrill Gorcunov
2008-09-05 18:11       ` Ingo Molnar
2008-09-05 18:33         ` Cyrill Gorcunov
2008-09-05 18:38           ` Ingo Molnar
2008-09-05 19:15             ` Cyrill Gorcunov
2008-09-06 10:15             ` Cyrill Gorcunov
2008-09-06 13:12               ` Ingo Molnar
2008-09-08  0:24                 ` Yinghai Lu
2008-09-08  4:18                   ` Cyrill Gorcunov
2008-09-08  4:20                   ` Cyrill Gorcunov
2008-09-08  4:38                     ` Yinghai Lu
2008-09-08  5:07                       ` Yinghai Lu
2008-09-08  5:17                         ` Cyrill Gorcunov
2008-09-06 18:45               ` Maciej W. Rozycki
2008-09-06 18:49                 ` Ingo Molnar
2008-09-06 20:02                   ` Maciej W. Rozycki
2008-09-07 10:00                   ` Cyrill Gorcunov
2008-09-07 15:47                     ` Ingo Molnar
2008-09-07 16:04                       ` Cyrill Gorcunov
2008-09-06 19:04                 ` Cyrill Gorcunov
2008-09-06 19:16                   ` Yinghai Lu
2008-09-06 19:19                     ` Cyrill Gorcunov
2008-09-06 19:38                     ` Cyrill Gorcunov
2008-09-06 19:44                       ` Cyrill Gorcunov
2008-09-06 20:08                         ` Maciej W. Rozycki
2008-09-06 20:13                           ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48c02b6a.0637560a.15e9.ffffa39d@mx.google.com \
    --to=gorcunov@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macro@linux-mips.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox