From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65AEB2AF1D for ; Tue, 25 Mar 2025 10:15:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742897722; cv=none; b=jlNRI64Oy73/ca65X64nU8oG0Y3taqTEvM1FbfG9OCtsQXeZJuN2VhKDWu3EgQHf4fOKjzNBgjiS7XPJqU8OzdpheyBexO1KRqwUYKjNl/XzDh++lbD4Dt86yYaimKpRMIdCSD4IzJUTNAns4YFod7Uo6d9HYCZ72hL49LFRNqs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742897722; c=relaxed/simple; bh=HIiymNtPWSmafw/vlEzUs3yK38VavdvhdwhqdM6/8zU=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=J3HcixqbD3vejwNLa9yWr+evvZMIk0HpCFKo03Gqa1zZm3ELTAMSoBiUCXAuPRhPe4uZyv2Td+t7qyyQzsac7JN1jK/KpFtqvqsYUtudcrixYZL4K/OJaRi0QHktd4NLpeoeoty3TIqPZnuseBsIGeXBHzFL1uoipQukc3C9fvg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wnYS7xt9; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wnYS7xt9" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4394345e4d5so33818545e9.0 for ; Tue, 25 Mar 2025 03:15:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742897718; x=1743502518; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=HIiymNtPWSmafw/vlEzUs3yK38VavdvhdwhqdM6/8zU=; b=wnYS7xt9skdjDZQardDs2MX4RWd/7Hz9oiEZT71HZULshe31/PUfeGxOaqom3RvRcv 3uZ2N//AJ0pJ9xWlMM3dk9Na+ZJjhJH6E7NQ+ITtCh0Tayc6E+jHNYg6yhmdzqq6GtfZ MNKd2pfpghNQ1KKV08/0aYkVI1tNNVXpWgFY+alSftJ3hCtQFIfq0sOc+ld8K62N/LcB B66AsZ2cHsZ788XHRgU+yzFAvesxAqw6q6PTWvIZCx1MdFHBQa4jQv+AtBLJrZv8cKt7 ntaLLQ0qkcDp4RSybC6nYBRzuYpR1Va/4FUXGWECQhDmbUnxueHf21eghbk7yKMiiKYF RZnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742897718; x=1743502518; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=HIiymNtPWSmafw/vlEzUs3yK38VavdvhdwhqdM6/8zU=; b=itqClVLVufZIllNHA4NLQOPCn7ZyKFDEqL+Xf5MDu826pCmNrqx1cw5IY27Ia/IbBx vWyOuAKP35Z91Fs8XI5qGnlWAhmDgRVysqkcdqKiAVRe8a71VfHr9eQfVZ0FWKQsLQ6d r+wHdLs8SRqojL5k2VUjm65Syu1rPXat2vFEOVOYU4025lwB1GpDyXBFrT56crN29nC+ ZpO6OcaNHsxrD/oLWCH6AMssOywHBPJy+a2ZdB5MkmmXeEEVWgoPnHBK6f35L3CB2gAe qLqMeGG7Hm0ocvCwtIPP8MbF5YCqOnheLSObylcwWe9jFkiUA2BaFZb+7m3aPKJRAphN loCA== X-Forwarded-Encrypted: i=1; AJvYcCXtUixXAQz/rOdZR/QDXOOyNm2MHG5F/Y0clFnCdaDiVNaPGjFyeQcTIEu0/H57S72UJCDJVZ6KM3Kt5Sw=@vger.kernel.org X-Gm-Message-State: AOJu0YzglbJDlYZoI1LfC1hlj4a/FPJkYA5J1O1IZoyHL/uRvEsfdtNr 9oWfizasme6u2gTtWpYUlFc1z5Ln/cAWVNPvnj6X793hQeYm4VS6PHYM19k1QM0= X-Gm-Gg: ASbGncsifY5tr8FDU9bJ/aU9i6qcwVNxaD7sk11yupnJgbe+GpEmPgyLYNHEMmIin8Q bIVPIbwcx6Wbe+FP09zODF2paW469cDZl13lSpnFoyavHx8Rto2PWdBbBSs3HvVwgk9py2maIrw J4t+poOrzoTGLiYl6BkldNIB4ja9b9m5v0cm2brJEm5Nv92PxvbzPZYUurE4OtaO/9uizNcGGk/ Gclc/K2Vb6a6+MsdDSPV24SnIxGkEL7EPt7h6iShOg3x+xQSJcM3xaOuNv5NCCGVbCs0qNro2dG 7tFWlYkWGGfgc1ZKA+AwTstrUaBWvU5Zkqifmx/nOQJTIXk6sw== X-Google-Smtp-Source: AGHT+IFw2/pNQ5VlOB5j+GWsibTCWxrlkUBFFVpMfhBQZ4qA20RXRLBX1Zd3wl5pSv2Zad5KMtYTBw== X-Received: by 2002:a05:600c:1f10:b0:43c:e2dd:98ea with SMTP id 5b1f17b1804b1-43d5a32ce3amr105676265e9.22.1742897717551; Tue, 25 Mar 2025 03:15:17 -0700 (PDT) Received: from [10.1.1.109] ([80.111.64.44]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d4fd9ec84sm144043865e9.26.2025.03.25.03.15.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Mar 2025 03:15:17 -0700 (PDT) Message-ID: <48c082ffbb6eaa75eacbf3c7cbf0e4caec441bfc.camel@linaro.org> Subject: Re: [PATCH v3 0/2] firmware: exynos-acpm: allow use during system shutdown From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Tudor Ambarus , Krzysztof Kozlowski , Alim Akhtar Cc: Peter Griffin , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Tue, 25 Mar 2025 10:15:16 +0000 In-Reply-To: <20250325-acpm-atomic-v3-0-c66aae7df925@linaro.org> References: <20250325-acpm-atomic-v3-0-c66aae7df925@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.53.2-1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2025-03-25 at 09:46 +0000, Andr=C3=A9 Draszik wrote: > One user of this ACPM driver is a PMIC driver that needs to communicate > with the PMIC during late system shutdown [1] and at that time we are > not allowed to sleep anymore. >=20 > This series address this by switching the code to using udelay() in the > specific case of system shutdown. This approach was inspired by I2C's > i2c_in_atomic_xfer_mode(), which has to deal with a similar corner > case. Looks like I forgot to update the paragraph here. As of v3, we now use udelay() unconditionally, instead of the fragile approach inspired by I2C, as suggested by Krzysztof. A. >=20 > Link: https://lore.kernel.org/all/20250323-s2mpg10-v1-29-d08943702707@lin= aro.org/=C2=A0[1] >=20 > Signed-off-by: Andr=C3=A9 Draszik > --- > Changes in v3: > - switch to unconditional udelay() (Krzysztof) > - Link to v2: https://lore.kernel.org/r/20250324-acpm-atomic-v2-0-7d87746= e1765@linaro.org >=20 > Changes in v2: > - add missing ktime.h include > - switch to ktime_before() instead of !ktime_after() > - add link to user requiring this change to cover letter > - collect Tudor's Rb > - Link to v1: https://lore.kernel.org/r/20250321-acpm-atomic-v1-0-fb887bd= e7e61@linaro.org >=20 > --- > Andr=C3=A9 Draszik (2): > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 firmware: exynos-acpm: use ktime APIs for = timeout detection > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 firmware: exynos-acpm: allow use during sy= stem shutdown >=20 > =C2=A0drivers/firmware/samsung/exynos-acpm.c | 16 ++++++++-------- > =C2=A01 file changed, 8 insertions(+), 8 deletions(-) > --- > base-commit: 9388ec571cb1adba59d1cded2300eeb11827679c > change-id: 20250321-acpm-atomic-033775b051ef >=20 > Best regards,