From: Cyrill Gorcunov <gorcunov@gmail.com>
To: mingo@elte.hu, macro@linux-mips.org, linux-kernel@vger.kernel.org
Cc: yhlu.kernel@gmail.com, Cyrill Gorcunov <gorcunov@gmail.com>
Subject: [patch 2/2] x86: apic - skip writting ESR register if we dont have on
Date: Sun, 14 Sep 2008 11:55:38 +0400 [thread overview]
Message-ID: <48ccc4e8.0c07560a.0cab.34d4@mx.google.com> (raw)
In-Reply-To: 20080914075536.619891882@gmail.com
[-- Attachment #1: x86-setup_local_APIC-esr-fix --]
[-- Type: text/plain, Size: 709 bytes --]
On 82489DX we don't have ESR register so we should not
write it.
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
Index: linux-2.6.git/arch/x86/kernel/apic.c
===================================================================
--- linux-2.6.git.orig/arch/x86/kernel/apic.c 2008-09-14 11:46:13.000000000 +0400
+++ linux-2.6.git/arch/x86/kernel/apic.c 2008-09-14 11:48:37.000000000 +0400
@@ -1131,7 +1131,7 @@ void __cpuinit setup_local_APIC(void)
#ifdef CONFIG_X86_32
/* Pound the ESR really hard over the head with a big hammer - mbligh */
- if (esr_disable) {
+ if (lapic_is_integrated() && esr_disable) {
apic_write(APIC_ESR, 0);
apic_write(APIC_ESR, 0);
apic_write(APIC_ESR, 0);
--
prev parent reply other threads:[~2008-09-14 8:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080914075536.619891882@gmail.com>
2008-09-14 7:55 ` [patch 1/2] x86: apic - lapic_setup_esr does not handle esr_disable - fix it Cyrill Gorcunov
2008-09-14 7:55 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48ccc4e8.0c07560a.0cab.34d4@mx.google.com \
--to=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mingo@elte.hu \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox