public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: mingo@elte.hu, macro@linux-mips.org, yhlu.kernel@gmail.com
Cc: linux-kernel@vger.kernel.org, Cyrill Gorcunov <gorcunov@gmail.com>
Subject: [patch 3/3] x86: apic - remove dead ifdef from lapic_is_integrated
Date: Wed, 24 Sep 2008 20:46:21 +0400	[thread overview]
Message-ID: <48da6f73.0637560a.586e.4ec0@mx.google.com> (raw)
In-Reply-To: 20080924164618.588609232@gmail.com

[-- Attachment #1: x86-apic-lapic_is_integrated-cleanup --]
[-- Type: text/plain, Size: 638 bytes --]

We already have #ifdef in apicdef.h which depends
on cpu type so no need to re-introduce it.

Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---

Index: linux-2.6.git/arch/x86/kernel/apic.c
===================================================================
--- linux-2.6.git.orig/arch/x86/kernel/apic.c	2008-09-24 19:33:31.000000000 +0400
+++ linux-2.6.git/arch/x86/kernel/apic.c	2008-09-24 20:25:05.000000000 +0400
@@ -167,11 +167,7 @@ static unsigned long apic_phys;
  */
 static inline int lapic_is_integrated(void)
 {
-#ifdef CONFIG_X86_64
-	return 1;
-#else
 	return APIC_INTEGRATED(lapic_get_version());
-#endif
 }
 
 /*

-- 

      parent reply	other threads:[~2008-09-24 16:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080924164618.588609232@gmail.com>
2008-09-24 16:46 ` [patch 1/3] x86: apic,io-apic - generalize lapic_get_version helper Cyrill Gorcunov
2008-09-24 16:46 ` [patch 2/3] x86: apic - simplify lapic_get_maxlvt Cyrill Gorcunov
2008-09-24 18:58   ` Hiroshi Shimamoto
2008-09-24 19:17     ` Yinghai Lu
2008-09-24 19:18     ` Cyrill Gorcunov
2008-09-24 19:24     ` Cyrill Gorcunov
2008-09-24 16:46 ` Cyrill Gorcunov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48da6f73.0637560a.586e.4ec0@mx.google.com \
    --to=gorcunov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macro@linux-mips.org \
    --cc=mingo@elte.hu \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox