From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6DDEC433E1 for ; Fri, 5 Jun 2020 21:09:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9C902074B for ; Fri, 5 Jun 2020 21:09:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="H8+UL+o0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728297AbgFEVJL (ORCPT ); Fri, 5 Jun 2020 17:09:11 -0400 Received: from linux.microsoft.com ([13.77.154.182]:57316 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727888AbgFEVJK (ORCPT ); Fri, 5 Jun 2020 17:09:10 -0400 Received: from [192.168.0.104] (c-73-42-176-67.hsd1.wa.comcast.net [73.42.176.67]) by linux.microsoft.com (Postfix) with ESMTPSA id 921A220B7185; Fri, 5 Jun 2020 14:09:09 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 921A220B7185 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1591391349; bh=i39FaZtY2X+kPAkTUw9+JdMbvXH6kXdMemItCH/9QYg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=H8+UL+o0s1ovdZmsSenHvljW70R+sD7tC/FyO+IktV1H/0jkcnoL6TxRShse5RtBx TnDqTHhp0IPI4e4ox1kS+pXCGj5yrduev0crKSSIqJkIltRXf7V5s8ws0KXQWa3NHv HfNSFN/I5lFhmpQ2uW1B5fGVjDejG/lq5j/4PZrE= Subject: Re: [PATCH] IMA: Add log statements for failure conditions To: Paul Moore Cc: Mimi Zohar , linux-integrity@vger.kernel.org, tusharsu@linux.microsoft.com, linux-kernel@vger.kernel.org, linux-audit@redhat.com References: <20200604163243.2575-1-nramas@linux.microsoft.com> <1591382782.5816.36.camel@linux.ibm.com> <8dfb3fa6-5c1f-d644-7d21-72a9448c52cc@linux.microsoft.com> From: Lakshmi Ramasubramanian Message-ID: <48ff60f1-df93-5ce7-a254-8bfd1dba2ade@linux.microsoft.com> Date: Fri, 5 Jun 2020 14:09:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/5/20 1:49 PM, Paul Moore wrote: > >> Since a pr_xyz() call was already present, I just wanted to change the >> log level to keep the code change to the minimum. But if audit log is >> the right approach for this case, I'll update. > > Generally we reserve audit for things that are required for various > security certifications and/or "security relevant". From what you > mentioned above, it seems like this would fall into the second > category if not the first. > > Looking at your patch it doesn't look like you are trying to record > anything special so you may be able to use the existing > integrity_audit_msg(...) helper. Of course then the question comes > down to the audit record type (the audit_msgno argument), the > operation (op), and the comm/cause (cause). > > Do you feel that any of the existing audit record types are a good fit for this? > Maybe I can use the audit_msgno "AUDIT_INTEGRITY_PCR" with appropriate strings for "op" and "cause". Mimi - please let me know if you think this audit_msgno would be ok to use. I see this code used, for instance, for boot aggregate measurement. integrity_audit_msg(AUDIT_INTEGRITY_PCR, NULL, boot_aggregate_name, op, audit_cause, result, 0); thanks, -lakshmi