From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754923AbbLIKBa (ORCPT ); Wed, 9 Dec 2015 05:01:30 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:50810 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750849AbbLIKBY (ORCPT ); Wed, 9 Dec 2015 05:01:24 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: "Yankejian (Hackim Yim)" , mark.rutland@arm.com, lisheng011@huawei.com, salil.mehta@huawei.com, liguozhu@huawei.com, haifeng.wei@huawei.com, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, xuwei5@hisilicon.com, devicetree@vger.kernel.org, robh+dt@kernel.org, huangdaode@hisilicon.com, galak@codeaurora.org, netdev@vger.kernel.org, fengguang.wu@intel.com, Yisen.Zhuang@huawei.com, davem@davemloft.net Subject: Re: arRe: [PATCH net-next 2/2] net: hns: enet specisies a reference to dsaf (config and documents) Date: Wed, 09 Dec 2015 11:00:21 +0100 Message-ID: <4902591.DhWVhdI4KP@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <5667F379.2010108@huawei.com> References: <1449295856-31068-1-git-send-email-yankejian@huawei.com> <1503684.BNZUVaD74W@wuerfel> <5667F379.2010108@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:lxUjtbT9zV4wxe7JYrMjPMTaK8c6Bdn0eKYiJU2cBuwUtuaadUl kf/NrRj8bsU3VQlcEfqQYWAqYTJsDfLMFQbQLoyC6E7fae1qqzYXMO3YMxa+1iNZdmqGxgn rfSmnRQtXbaeBx11YtgCTAMKP3epG8sltltd0hwukWVLDSpvcwmMFXaLSAY9nxHqIvuBC53 1oW8Opccp5NBaIh4RtRfw== X-UI-Out-Filterresults: notjunk:1;V01:K0:Y7H5HFVxczo=:8ItM7hJkgo3za1UP9Blypm Rny4eb2TREtzgpNMIZw7jJ6+VdJ5gUOM9ukPfXTmZUGJBw3ftLddM6iTKWq8RQxzYl4e/tqH1 cRC5Y8boFaSWiK0mywqeHAp/9Qbrgr15aJ9pLmqKHuPeslkb9LcYrRfWvpu/yNdmhOxOzlBHS r62nSYZDSbk3JWK3tedTSuUAJB81MsF2oQbVMzEFX/oUr8HyqtbouxD2fDVDEKRFsfQ+UFp7n 7ojlwqxD7NIAhKjiVXdR0G3ZWAiLzD6sV1AkiuAYPaMKpWK+jsKzFsKjH+TwUqcukZrF7JK82 P4+3H0GYcdTd9+WeH7r5Jy1PGGyOC7aLJIDEKDHb81lY0EFVmU8GwSxisnHdO7BV55SN6xfyo 2yNRnXNAybvCVLRNt2LfPdxaCEL4lduttO9rDUA+vMAnCR+am4qvnhVyP4Z4Rh6crN3o4XwH9 rGi3XvRMFvKE6RQ0ieI+Uf1VDdftqEvXJ1MaBISKClXTwdGYbmzNiqF4f1ZsOK1szKHtadI8Q QXJAMz2bi+fy3+LZv78FyLhQNjFiTA/AumqO0PxWOaOhHL//63W8QbMoPk+eFW9GXvZaheOTd vUQGeceXl5esvwolaBkEnUXTmLV9MgNefbgNCen0BSJamMVYzEsHJwfp4CHd6ghv+qMi0h1zT HG10zC0j7XJ+gFh+RDyeGNf5EEL4mBqatXpa7xiiRuepNeXWTcAHFqzcVo79DGS9VityQLp8B of2DBqKILu1D6AA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 09 December 2015 17:25:13 Yankejian wrote: > thanks a lot for pointing it out. > > It is great regret that this change breaks compatibility with old dtbs. > this is a new driver which is run on developing boards, and all the > clients' boards are developing boards. So we provide them a method to > update the firmware on the board, once we update the dtsi and kernel, > we require our clients to update the existed firmware and kernel. > Therefore, these changes is actually under control. Shall we treat this > by this way? Ok, if you can show that the incompatible change is safe to do, that's fine. Just put the explanation above into the patch description to document that you have considered the effects of the change, and to ensure that it gets done atomically. Also, you have to merge the two patches into one to allow bisection, or do a series of three patches that need to be applied in order: 1. add ae-handle property 2. change driver to use that property 3. remove ae-name property Arnd