From: Manfred Spraul <manfred@colorfullife.com>
To: Nadia.Derbey@bull.net
Cc: cboulte@gmail.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SYSVIPC - Fix the ipc structures initialization
Date: Tue, 28 Oct 2008 18:22:43 +0100 [thread overview]
Message-ID: <49074A63.1090105@colorfullife.com> (raw)
In-Reply-To: <20081028150041.857635775@bull.net>
Nadia.Derbey@bull.net wrote:
> Index: linux-2.6.27/ipc/util.c
> ===================================================================
> --- linux-2.6.27.orig/ipc/util.c 2008-10-23 15:20:46.000000000 +0200
> +++ linux-2.6.27/ipc/util.c 2008-10-28 16:52:17.000000000 +0100
> @@ -266,9 +266,17 @@ int ipc_addid(struct ipc_ids* ids, struc
> if (ids->in_use >= size)
> return -ENOSPC;
>
> + spin_lock_init(&new->lock);
> + new->deleted = 0;
>
Is "new->deleted = 0" still necessary?
Acquiring the lock should be sufficient.
--
Manfred
next prev parent reply other threads:[~2008-10-28 17:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081028145952.620752409@bull.net>
2008-10-28 14:59 ` [PATCH] SYSVIPC - Fix the ipc structures initialization Nadia.Derbey
2008-10-28 17:22 ` Manfred Spraul [this message]
2008-10-29 9:11 ` cboulte
2008-11-11 22:16 ` Andrew Morton
2008-11-12 6:41 ` Manfred Spraul
2008-11-13 6:10 ` Manfred Spraul
2008-11-13 8:06 ` Peter Zijlstra
2008-11-13 10:08 ` Nadia Derbey
2008-11-13 17:53 ` Manfred Spraul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49074A63.1090105@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=Nadia.Derbey@bull.net \
--cc=akpm@linux-foundation.org \
--cc=cboulte@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox