From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Pavel Machek <pavel@ucw.cz>, Xing Zhang <Xing.Zhang@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Dan Murphy <dmurphy@ti.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v1] Add support for MediaTek regulator vibrator driver
Date: Thu, 7 May 2020 22:45:35 +0200 [thread overview]
Message-ID: <49089bf3-d64b-2a50-269c-623a6ea9c14c@gmail.com> (raw)
In-Reply-To: <20200507174519.GD1216@bug>
Hi Pavel,
On 5/7/20 7:45 PM, Pavel Machek wrote:
> Hi!
>
>> This patchset add regulator vibrator driver for MTK Soc. The driver
>> controls vibrator through regulator's enable and disable.
>
> We'd prefer not to have vibrators in led subsystem.
>
>>
>> Xing Zhang (3):
>> dt-bindings: add regulator vibrator documentation
>> arm64: mediatek: Add regulator vibrator support
>> Vibrator: Add regulator vibrator driver
>>
>> .../bindings/leds/regulator-vibrator.txt | 39 ++
>> arch/arm64/configs/defconfig | 1 +
>> drivers/leds/Kconfig | 10 +
>> drivers/leds/Makefile | 1 +
>> drivers/leds/regulator-vibrator.c | 450 ++++++++++++++++++
>
> OTOH, connecting LED to regulator might make some sense. I can take the driver with
> vibrator functionality stripped, provided it is named the usual way...
We already had an attempt of solving this in more generic way [0],
but you opposed then [1]. Just for the record.
[0]
https://lore.kernel.org/linux-leds/20170913175400.42744-1-dtwlin@google.com/
[1] https://lore.kernel.org/linux-leds/20170914205804.GA24339@amd/
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2020-05-07 20:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 8:17 [PATCH v1] Add support for MediaTek regulator vibrator driver Xing Zhang
2020-04-29 8:17 ` [PATCH v1 1/3] dt-bindings: add regulator vibrator documentation Xing Zhang
2020-04-29 8:18 ` [PATCH v1 2/3] arm64: mediatek: Add regulator vibrator support Xing Zhang
2020-04-29 8:18 ` [PATCH v1 3/3] Vibrator: Add regulator vibrator driver Xing Zhang
2020-05-07 17:45 ` [PATCH v1] Add support for MediaTek " Pavel Machek
2020-05-07 20:45 ` Jacek Anaszewski [this message]
2020-05-07 21:09 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49089bf3-d64b-2a50-269c-623a6ea9c14c@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=Xing.Zhang@mediatek.com \
--cc=dmurphy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox