* [PATCH] add include list.h in binfmts.h
@ 2008-10-30 1:03 Hiroshi Shimamoto
2008-11-11 0:12 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Hiroshi Shimamoto @ 2008-10-30 1:03 UTC (permalink / raw)
To: linux-kernel; +Cc: Andrew Morton
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
linux_binfmt uses list_head, so list.h is needed.
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
---
include/linux/binfmts.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/binfmts.h b/include/linux/binfmts.h
index 7394b5b..06c1123 100644
--- a/include/linux/binfmts.h
+++ b/include/linux/binfmts.h
@@ -1,6 +1,7 @@
#ifndef _LINUX_BINFMTS_H
#define _LINUX_BINFMTS_H
+#include <linux/list.h>
#include <linux/capability.h>
struct pt_regs;
--
1.5.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] add include list.h in binfmts.h
2008-10-30 1:03 [PATCH] add include list.h in binfmts.h Hiroshi Shimamoto
@ 2008-11-11 0:12 ` Andrew Morton
2008-11-11 0:40 ` Hiroshi Shimamoto
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2008-11-11 0:12 UTC (permalink / raw)
To: Hiroshi Shimamoto; +Cc: linux-kernel
On Wed, 29 Oct 2008 18:03:26 -0700
Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>
> linux_binfmt uses list_head, so list.h is needed.
>
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> ---
> include/linux/binfmts.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/binfmts.h b/include/linux/binfmts.h
> index 7394b5b..06c1123 100644
> --- a/include/linux/binfmts.h
> +++ b/include/linux/binfmts.h
> @@ -1,6 +1,7 @@
> #ifndef _LINUX_BINFMTS_H
> #define _LINUX_BINFMTS_H
>
> +#include <linux/list.h>
> #include <linux/capability.h>
>
> struct pt_regs;
Did this fix a build error which you were seeing?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] add include list.h in binfmts.h
2008-11-11 0:12 ` Andrew Morton
@ 2008-11-11 0:40 ` Hiroshi Shimamoto
0 siblings, 0 replies; 3+ messages in thread
From: Hiroshi Shimamoto @ 2008-11-11 0:40 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
Andrew Morton wrote:
> On Wed, 29 Oct 2008 18:03:26 -0700
> Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:
>
>> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>>
>> linux_binfmt uses list_head, so list.h is needed.
>>
>> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>> ---
>> include/linux/binfmts.h | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/linux/binfmts.h b/include/linux/binfmts.h
>> index 7394b5b..06c1123 100644
>> --- a/include/linux/binfmts.h
>> +++ b/include/linux/binfmts.h
>> @@ -1,6 +1,7 @@
>> #ifndef _LINUX_BINFMTS_H
>> #define _LINUX_BINFMTS_H
>>
>> +#include <linux/list.h>
>> #include <linux/capability.h>
>>
>> struct pt_regs;
>
> Did this fix a build error which you were seeing?
I just noticed it modifying arch/x86/kernel/signal_32.c headers.
I don't know any case to fail build kernel.
The file signal_32.c includes <linux/list.h> first, and To remove
including list.h causes a build error.
thanks,
Hiroshi Shimamoto
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-11-11 0:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-30 1:03 [PATCH] add include list.h in binfmts.h Hiroshi Shimamoto
2008-11-11 0:12 ` Andrew Morton
2008-11-11 0:40 ` Hiroshi Shimamoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox