From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753496AbYJaEtM (ORCPT ); Fri, 31 Oct 2008 00:49:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751738AbYJaEsw (ORCPT ); Fri, 31 Oct 2008 00:48:52 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:54176 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750867AbYJaEsv (ORCPT ); Fri, 31 Oct 2008 00:48:51 -0400 Message-ID: <490A8E2E.7050502@garzik.org> Date: Fri, 31 Oct 2008 00:48:46 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: chunbo.luo@windriver.com CC: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] amd811e: fix dma_free_coherent warning References: <1225158706-5700-1-git-send-email-chunbo.luo@windriver.com> In-Reply-To: <1225158706-5700-1-git-send-email-chunbo.luo@windriver.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.5 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org chunbo.luo@windriver.com wrote: > From: Chunbo Luo > > Acoording commit aa24886e379d2b641c5117e178b15ce1d5d366ba, > dma_free_coherent() need irqs enabled. > > This patch fix following warning messages: > > WARNING: at linux/arch/x86/kernel/pci-dma.c:376 dma_free_coherent+0xaa/0xb0() > > Call Trace: > [] warn_on_slowpath+0x5f/0x90 > [] ? __kfree_skb+0x3a/0xa0 > [] ? discard_slab+0x23/0x40 > [] dma_free_coherent+0xaa/0xb0 > [] amd8111e_close+0x10f/0x1b0 > [] dev_close+0x5e/0xb0 > [] dev_change_flags+0xa1/0x1e0 > [] ic_close_devs+0x36/0x4e > [] ip_auto_config+0x581/0x10f3 > [] ? kobject_add+0x69/0x90 > [] ? kobject_get+0x1a/0x30 > [] ? kobject_uevent+0xb/0x10 > [] ? kset_register+0x52/0x60 > [] ? kset_create_and_add+0x6b/0xa0 > [] ? tcp_ca_find+0x24/0x50 > [] ? ip_auto_config+0x0/0x10f3 > [] _stext+0x3c/0x150 > [] ? register_irq_proc+0xd3/0xf0 > [] ? mb_cache_create+0x80/0x1f0 > [] kernel_init+0x141/0x1b8 > [] ? kernel_init+0x0/0x1b8 > [] child_rip+0xa/0x11 > [] ? kernel_init+0x0/0x1b8 > [] ? kernel_init+0x0/0x1b8 > [] ? child_rip+0x0/0x11 > > Signed-off-by: Chunbo Luo > --- > drivers/net/amd8111e.c | 9 ++++----- > 1 files changed, 4 insertions(+), 5 deletions(-) applied