From: Jiri Slaby <jirislaby@gmail.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Jeroen Roovers <jer@gentoo.org>, Helge Deller <deller@gmx.de>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] USBHID: correct start/stop cycle
Date: Sun, 02 Nov 2008 00:07:20 +0100 [thread overview]
Message-ID: <490CE128.3020007@gmail.com> (raw)
In-Reply-To: <alpine.LNX.1.10.0811020000360.29633@jikos.suse.cz>
On 11/02/2008 12:02 AM, Jiri Kosina wrote:
> On Sat, 1 Nov 2008, Jiri Slaby wrote:
>
>> `stop' left out usbhid->urb* pointers and so the next `start' thought
>> it needs to allocate nothing and used the memory pointers previously
>> pointed to. This led to memory corruption and device malfunction.
[...]
> could you please verify whether this patch fixes the corruption you were
> experiencing?
btw. this is not expected to fix that, but if it does, the better ;).
This fixes
echo DEVICE > /sys/bus/hid/drivers/DRIVER/unbind
echo DEVICE > /sys/bus/hid/drivers/DRIVER/bind
failures.
But maybe parisc does something differently than x86 in bus handling so that it
triggers...
next prev parent reply other threads:[~2008-11-01 23:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-01 22:41 [PATCH 1/1] USBHID: correct start/stop cycle Jiri Slaby
2008-11-01 23:02 ` Jiri Kosina
2008-11-01 23:07 ` Jiri Slaby [this message]
2008-11-02 10:43 ` Helge Deller
2008-11-02 10:55 ` Jiri Slaby
2008-11-02 16:50 ` Helge Deller
2008-11-02 19:24 ` Denys Vlasenko
2008-11-11 23:22 ` Jiri Kosina
2008-11-12 0:24 ` Denys Vlasenko
2008-11-12 0:34 ` Who broke cb8f488c33 patch? (was Re: [PATCH 1/1] USBHID: correct start/stop cycle) Jiri Kosina
2008-11-12 0:50 ` Andrew Morton
2008-11-12 9:23 ` Jiri Slaby
2008-11-13 15:32 ` Helge Deller
2008-11-13 16:22 ` Linus Torvalds
2008-11-11 22:52 ` [PATCH 1/1] USBHID: correct start/stop cycle Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490CE128.3020007@gmail.com \
--to=jirislaby@gmail.com \
--cc=deller@gmx.de \
--cc=jer@gentoo.org \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox