public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Geoff Levand <geoffrey.levand@am.sony.com>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Paul Mackerras <paulus@samba.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Greg KH <greg@kroah.com>
Subject: Re: powerpc: struct device - replace bus_id with dev_name(),	dev_set_name()
Date: Mon, 3 Nov 2008 15:15:08 -0800	[thread overview]
Message-ID: <490F85FC.9000001@am.sony.com> (raw)
In-Reply-To: <1225594904.2142.26.camel@nga.site>

Kay Sievers wrote:
> (I did not compile or test it, please let me know, or help fixing
>  it, if something is wrong with the conversion)
> 
> This patch is part of a larger patch series which will remove
> the "char bus_id[20]" name string from struct device. The device
> name is managed in the kobject anyway, and without any size
> limitation, and just needlessly copied into "struct device".
> 
> To set and read the device name dev_name(dev) and dev_set_name(dev)
> must be used. If your code uses static kobjects, which it shouldn't
> do, "const char *init_name" can be used to statically provide the
> name the registered device should have. At registration time, the
> init_name field is cleared, to enforce the use of dev_name(dev) to
> access the device name at a later time.
> 
> We need to get rid of all occurrences of bus_id in the entire tree
> to be able to enable the new interface. Please apply this patch,
> and possibly convert any remaining remaining occurrences of bus_id.
> 
> We want to submit a patch to -next, which will remove bus_id from
> "struct device", to find the remaining pieces to convert, and finally
> switch over to the new api, which will remove the 20 bytes array
> and does no longer have a size limitation.
> 
> Thanks,
> Kay
> 
> 
> From: Kay Sievers <kay.sievers@vrfy.org>
> Subject: powerpc: struct device - replace bus_id with dev_name(), dev_set_name()
> 
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Geoff Levand <geoffrey.levand@am.sony.com>
> Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
> Signed-Off-By: Kay Sievers <kay.sievers@vrfy.org>
> ---
>  arch/powerpc/kernel/ibmebus.c             |    2 +-
>  arch/powerpc/kernel/of_device.c           |   18 +++++++-----------
>  arch/powerpc/kernel/vio.c                 |   12 ++++++------
>  arch/powerpc/platforms/85xx/mpc85xx_mds.c |    6 +++---
>  arch/powerpc/platforms/ps3/system-bus.c   |   28 ++++++++++++----------------
>  5 files changed, 29 insertions(+), 37 deletions(-)

The PS3 parts look OK.  I think if it builds with ps3_defconfig then
it will work.

Acked-by: Geoff Levand <geoffrey.levand@am.sony.com>





      reply	other threads:[~2008-11-03 23:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-02  3:01 powerpc: struct device - replace bus_id with dev_name(), dev_set_name() Kay Sievers
2008-11-03 23:15 ` Geoff Levand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=490F85FC.9000001@am.sony.com \
    --to=geoffrey.levand@am.sony.com \
    --cc=greg@kroah.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox