public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mm: print out memmap number only it is not zero
@ 2008-11-04  1:39 Yinghai Lu
  2008-11-04  8:59 ` Ingo Molnar
  0 siblings, 1 reply; 2+ messages in thread
From: Yinghai Lu @ 2008-11-04  1:39 UTC (permalink / raw)
  To: Andrew Morton, Ingo Molnar, Thomas Gleixner, H. Peter Anvin
  Cc: linux-kernel@vger.kernel.org


Impact: cleanup

not print out for non used zone on nodes other than node0

Signed-off-by: Yinghai Lu <yinghai@kernel.org>

---
 mm/page_alloc.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Index: linux-2.6/mm/page_alloc.c
===================================================================
--- linux-2.6.orig/mm/page_alloc.c
+++ linux-2.6/mm/page_alloc.c
@@ -3451,9 +3451,10 @@ static void __paginginit free_area_init_
 			PAGE_ALIGN(size * sizeof(struct page)) >> PAGE_SHIFT;
 		if (realsize >= memmap_pages) {
 			realsize -= memmap_pages;
-			printk(KERN_DEBUG
-				"  %s zone: %lu pages used for memmap\n",
-				zone_names[j], memmap_pages);
+			if (memmap_pages)
+				printk(KERN_DEBUG
+				       "  %s zone: %lu pages used for memmap\n",
+				       zone_names[j], memmap_pages);
 		} else
 			printk(KERN_WARNING
 				"  %s zone: %lu pages exceeds realsize %lu\n",

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mm: print out memmap number only it is not zero
  2008-11-04  1:39 [PATCH] mm: print out memmap number only it is not zero Yinghai Lu
@ 2008-11-04  8:59 ` Ingo Molnar
  0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-11-04  8:59 UTC (permalink / raw)
  To: Yinghai Lu
  Cc: Andrew Morton, Thomas Gleixner, H. Peter Anvin,
	linux-kernel@vger.kernel.org


* Yinghai Lu <yinghai@kernel.org> wrote:

> Impact: cleanup

Impact: simplify debug printk output

> not print out for non used zone on nodes other than node0
> 
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>

looks good to me.

	Ingo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-11-04  8:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-04  1:39 [PATCH] mm: print out memmap number only it is not zero Yinghai Lu
2008-11-04  8:59 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox