Re: [PATCH 3/6] rz1000: apply chipset quirks early

Sergei Shtylyov
2008-11-04T18:56:35Z

Hello, I wrote:

>> Index: b/drivers/ide/rz1000.c
>> ===================================================================
>> --- a/drivers/ide/rz1000.c
>> +++ b/drivers/ide/rz1000.c
>> @@ -22,34 +22,48 @@
>>
>> #define DRV_NAME "rz1000"
>>
>> -static void __devinit init_hwif_rz1000 (ide_hwif_t *hwif)
>> +static unsigned int __devinit rz1000_init_chipset(struct pci_dev *dev)

> Hm, this is not a real init_chipset() method and it does just one
> thing -- disables readahead, so rz1000_disable_readahead() or something
> of that sort seems like a better name...

Hm, 'unsigned' result type wasn't terribly helpful here as well. :-)

MBR, Sergei