Re: [PATCH 3/6] rz1000: apply chipset quirks early

Sergei Shtylyov
2008-11-04T17:18:53Z

Hello.

Bartlomiej Zolnierkiewicz wrote:

> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rz1000: apply chipset quirks early

> * Use pci_name(dev) instead of hwif->name in init_hwif_rz1000().

> * init_hwif_rz1000() -> rz1000_init_chipset(). Update rz1000_init_one()
> to use rz1000_init_chipset() and add now required rz1000_remove().

> * Remove superfluous ide_rz1000 chipset type.

> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

> Index: b/drivers/ide/rz1000.c
> ===================================================================
> --- a/drivers/ide/rz1000.c
> +++ b/drivers/ide/rz1000.c
> @@ -22,34 +22,48 @@
>
> #define DRV_NAME "rz1000"
>
> -static void __devinit init_hwif_rz1000 (ide_hwif_t *hwif)
> +static unsigned int __devinit rz1000_init_chipset(struct pci_dev *dev)

Hm, this is not a real init_chipset() method and it does just one thing --
disables readahead, so rz1000_disable_readahead() or something of that sort
seems like a better name...

MBR, Sergei