> On 11/05/2008 10:27 AM, Lior Dotan wrote: >> This patch uses kzalloc() where really applicable. > > ack this, but there is another problem. > > sizeof(struct physcard *) is wrong size for that allocation, care to send a fix > for this (and revice the rest of allocations)? I wonder how this could work with Fix attached. I only found two other places with the same problem. > SLAB_DEBUG on, maybe nobody tried... AFAIK there aren't a lot of testers for this drivers so the few that does probably didn't try it. Fix sizeof to use the right type Signed-off-by: Lior Dotan