From: "Éric Piel" <Eric.Piel@tremplin-utc.net>
To: Pavel Machek <pavel@suse.cz>, Andrew Morton <akpm@osdl.org>
Cc: Thomas Renninger <trenn@suse.de>,
burman.yan@gmail.com, rpurdie@rpsys.net,
LKML <linux-kernel@vger.kernel.org>,
Len Brown <len.brown@intel.com>, Kay Sievers <kasievers@suse.de>,
hmh@hmh.eng.br
Subject: Re: leds-hp-disk vs lis3lv02d
Date: Thu, 06 Nov 2008 22:45:05 +0100 [thread overview]
Message-ID: <49136561.1050907@tremplin-utc.net> (raw)
In-Reply-To: <20081106121405.GA1601@ucw.cz>
Pavel Machek schreef:
>>> OTOH it should
>>> not block merge; both drivers still work and are useful.
>> But for long-term the HPQ0004 specific things in the lids3v driver should get
>> merged with your HP leds driver also registering for HPQ0004 and the lids3v
>> specific things should get a separate driver which HPQ0004 driver makes use
>> of?
>> So in the end also for the HPQ0004 device only one driver should register for?
>
> Yep... and this is the step in that direction. Relative to my previous
> patch...
>
> Later led stuff will get merged to hp_accel.c...
Hi Pavel,
Just to say I like this approach. It should be completely compatible
with the idea of allowing different buses (SPI and I²C) as well. Of
course, I wish it could be possible to have the led and accelerometer
drivers separated because they have no common point but the fact that
they are advertised by the same PNP ID. But I can deal with that.
Andrew, is there anything preventing the merge of the lis3lv02d driver
from your tree to Linus' one? I think it's still worth to integrate it
as is, and later on this refactoring can take place.
See you,
Eric
next prev parent reply other threads:[~2008-11-06 21:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200810162255.m9GMtKj4001733@imap1.linux-foundation.org>
[not found] ` <200810192106.15905.trenn@suse.de>
[not found] ` <20081019204819.GC1465@ucw.cz>
2008-10-25 10:42 ` leds-hp-disk vs lis3lv02d Eric Piel
2008-10-26 17:40 ` Pavel Machek
2008-10-27 12:45 ` Thomas Renninger
2008-10-27 12:58 ` Kay Sievers
2008-10-27 13:03 ` Pavel Machek
2008-11-06 12:14 ` Pavel Machek
2008-11-06 21:45 ` Éric Piel [this message]
2008-11-06 22:22 ` Andrew Morton
2008-11-05 23:00 ` Pavel Machek
2008-11-10 11:59 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49136561.1050907@tremplin-utc.net \
--to=eric.piel@tremplin-utc.net \
--cc=akpm@osdl.org \
--cc=burman.yan@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=kasievers@suse.de \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=rpurdie@rpsys.net \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox