From: "Jan Beulich" <jbeulich@novell.com>
To: "Ingo Molnar" <mingo@elte.hu>, "Jeremy Fitzhardinge" <jeremy@goop.org>
Cc: "Ian Campbell" <Ian.Campbell@citrix.com>,
"xen devel" <xen-devel@lists.xensource.com>,
"Christopher S. Aker" <caker@theshore.net>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] 2.6.27 - SMP enabled, but only 1 CPU
Date: Fri, 07 Nov 2008 09:53:47 +0000 [thread overview]
Message-ID: <49141E3B.76E4.0078.0@novell.com> (raw)
In-Reply-To: <20081106222039.GA7505@elte.hu>
>>> Ingo Molnar <mingo@elte.hu> 06.11.08 23:20 >>>
>
>* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
>> Ingo Molnar wrote:
>>> where exactly is that use? My grep didnt show any users of pud_page().
>>> pud_page() was changed in an incompatible way, all users of it must be
>>> updated.
>>>
>>
>> pgd_page() uses it in pgtable-nopud.h, so any users of pgd_page()
>> also need to be looked at. It so happens the only user is
>> arch/x86/xen/mmu.c, which expects it to return the vaddr. Fixed
>> below.
>
>ah! asm-generic was missed by my grep. (and i suspect Jan missed it
>too)
Indeed - broken as it was I never even considered this could be used
somewhere in generic code.
>> Subject: xen: fix use of pgd_page now that it really does return a page
>
>applied to tip/x86/urgent, thanks!
And my thanks, too, Jeremy, for the quick spotting of the problem.
Jan
prev parent reply other threads:[~2008-11-07 9:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <48F3BC99.5040409@theshore.net>
[not found] ` <490F5F50.7020704@theshore.net>
[not found] ` <4910AD00.7040605@theshore.net>
[not found] ` <4911BC52.7040905@theshore.net>
[not found] ` <1225994697.12607.837.camel@zakaz.uk.xensource.com>
2008-11-06 19:15 ` [Xen-devel] 2.6.27 - SMP enabled, but only 1 CPU Jeremy Fitzhardinge
2008-11-06 21:16 ` Ingo Molnar
2008-11-06 21:20 ` Jeremy Fitzhardinge
2008-11-06 21:22 ` Ingo Molnar
2008-11-06 21:28 ` Jeremy Fitzhardinge
2008-11-06 21:33 ` Ingo Molnar
2008-11-06 21:48 ` Jeremy Fitzhardinge
2008-11-06 22:20 ` Ingo Molnar
2008-11-06 22:29 ` Jeremy Fitzhardinge
2008-11-07 9:53 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49141E3B.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=Ian.Campbell@citrix.com \
--cc=caker@theshore.net \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox