From: Randy Dunlap <randy.dunlap@oracle.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Joe Perches <joe@perches.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Darrick J. Wong" <djwong@us.ibm.com>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [PATCH 4/5] adt7473: Check inputs from sysfs writes
Date: Fri, 07 Nov 2008 13:02:37 -0800 [thread overview]
Message-ID: <4914ACED.8070207@oracle.com> (raw)
In-Reply-To: <20081107220019.74c60aa4@hyperion.delvare>
Jean Delvare wrote:
> On Fri, 07 Nov 2008 12:49:34 -0800, Joe Perches wrote:
>> On Fri, 2008-11-07 at 11:20 -0800, Andrew Morton wrote:
>>>> +#define ROUND_DIV(x, divisor) (((x) + ((divisor) / 2)) / (divisor))
>>> It might make sense to rename this to ROUND_CLOSEST, fix the
>>> double-evaluation and whap it into kernel.h?
>> ROUND_HALF_UP?
>
> What would that supposedly mean?
Just go with DIV_ROUND_CLOSEST() or DIV_ROUND().
The _CLOSEST() is redundant to ROUND .. IMO.
--
~Randy
next prev parent reply other threads:[~2008-11-07 21:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 18:56 [PATCH 0/5] Various hwmon patches Darrick J. Wong
2008-11-07 18:56 ` [PATCH 1/5] adt7462: New hwmon driver Darrick J. Wong
2008-11-07 19:04 ` Harvey Harrison
2008-11-07 19:27 ` Andrew Morton
2008-11-07 19:34 ` Darrick J. Wong
2008-11-07 19:38 ` Darrick J. Wong
2008-11-07 19:18 ` Andrew Morton
2008-11-07 18:56 ` [PATCH 2/5] i5k_amb: Load automatically on all 5000/5400 chipsets Darrick J. Wong
2008-11-08 11:09 ` Jean Delvare
2008-11-11 6:26 ` Greg KH
2008-11-07 18:56 ` [PATCH 3/5] adt7470: Check input range when sysfs files are written Darrick J. Wong
2008-11-11 0:22 ` Andrew Morton
2008-11-11 0:49 ` Darrick J. Wong
2008-11-07 18:56 ` [PATCH 4/5] adt7473: Check inputs from sysfs writes Darrick J. Wong
2008-11-07 19:20 ` Andrew Morton
2008-11-07 20:35 ` Jean Delvare
2008-11-07 20:49 ` Joe Perches
2008-11-07 21:00 ` Jean Delvare
2008-11-07 21:02 ` Randy Dunlap [this message]
2008-11-07 18:56 ` [PATCH 5/5] lm85: Support adt7468 chips Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4914ACED.8070207@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=djwong@us.ibm.com \
--cc=joe@perches.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox