From: Tejun Heo <tj@kernel.org>
To: Jens Axboe <jens.axboe@oracle.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/3] block: fix add_partition() error path
Date: Mon, 10 Nov 2008 15:28:59 +0900 [thread overview]
Message-ID: <4917D4AB.4080401@kernel.org> (raw)
Partition stats structure was not freed on devt allocation failure
path. Fix it.
Signed-off-by: Tejun Heo <tj@kernel.org>
---
fs/partitions/check.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Index: work/fs/partitions/check.c
===================================================================
--- work.orig/fs/partitions/check.c
+++ work/fs/partitions/check.c
@@ -395,7 +395,7 @@ int add_partition(struct gendisk *disk,
err = blk_alloc_devt(p, &devt);
if (err)
- goto out_free;
+ goto out_free_stats;
pdev->devt = devt;
/* delay uevent until 'holders' subdir is created */
@@ -426,6 +426,8 @@ int add_partition(struct gendisk *disk,
return 0;
+out_free_stats:
+ free_part_stats(p);
out_free:
kfree(p);
return err;
next reply other threads:[~2008-11-10 6:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-10 6:28 Tejun Heo [this message]
2008-11-10 6:29 ` [PATCH] block: make add_partition() return pointer to hd_struct Tejun Heo
2008-11-10 6:30 ` [PATCH 3/3] block/md: fix md autodetection Tejun Heo
2008-11-10 12:41 ` [PATCH 1/3] block: fix add_partition() error path Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4917D4AB.4080401@kernel.org \
--to=tj@kernel.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox