From: Alain Knaff <alain@knaff.lu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] VFS: lseek(fd, 0, SEEK_CUR) race condition
Date: Tue, 11 Nov 2008 07:37:54 +0100 [thread overview]
Message-ID: <49192842.8000604@knaff.lu> (raw)
In-Reply-To: <20081110170808.831093ec.akpm@linux-foundation.org>
Andrew Morton wrote:
[...]
> OK, I think that a concurrent lseek(fd, 0, SEEK_CUR) is a sufficiently
> sane operation that this is worth doing. As you point out, there is no
> other way of userspace doing what is effectively a read-only operation
> - userspace would be entitled to wonder "ytf did the kernel rewrite the
> file offset for that?".
>
>
> Do the below additions look OK?
Yes, these additions look ok to me. Thanks for your quick and easy reply.
> From: Andrew Morton <akpm@linux-foundation.org>
>
> - fix coding-style
> - fix default_llseek() as well
Wow, that one was missing an unlock_kernel()... I'm wondering why this
hadn't let to some major SNAFU...
> - add comments
Thanks,
Alain
prev parent reply other threads:[~2008-11-11 6:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-06 20:21 [PATCH] VFS: lseek(fd, 0, SEEK_CUR) race condition Alain Knaff
2008-11-11 1:08 ` Andrew Morton
2008-11-11 6:37 ` Alain Knaff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49192842.8000604@knaff.lu \
--to=alain@knaff.lu \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox