* [PATCH 3/3] fix multi_msi_enable()
@ 2008-11-11 10:47 Jan Beulich
0 siblings, 0 replies; only message in thread
From: Jan Beulich @ 2008-11-11 10:47 UTC (permalink / raw)
To: linux-pci; +Cc: linux-kernel
And isn't multi_msi_enable(), though unused (since msi_{en,dis}able() are
unused), broken altogether (shifting num right by 1 instead of taking the
binary log)?
Signed-off-by: Jan Beulich <jbeulich@novell.com>
---
drivers/pci/msi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.28-rc4/drivers/pci/msi.h 2007-02-04 19:44:54.000000000 +0100
+++ 2.6.28-rc4-pci-multi-msi-enable/drivers/pci/msi.h 2008-11-07 09:13:09.000000000 +0100
@@ -23,7 +23,7 @@
#define multi_msi_capable(control) \
(1 << ((control & PCI_MSI_FLAGS_QMASK) >> 1))
#define multi_msi_enable(control, num) \
- control |= (((num >> 1) << 4) & PCI_MSI_FLAGS_QSIZE);
+ control |= ((fls((num) - 1) << 4) & PCI_MSI_FLAGS_QSIZE)
#define is_64bit_address(control) (!!(control & PCI_MSI_FLAGS_64BIT))
#define is_mask_bit_support(control) (!!(control & PCI_MSI_FLAGS_MASKBIT))
#define msi_enable(control, num) multi_msi_enable(control, num); \
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-11-11 10:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-11 10:47 [PATCH 3/3] fix multi_msi_enable() Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox