From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752407AbYKKSrz (ORCPT ); Tue, 11 Nov 2008 13:47:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751791AbYKKSr2 (ORCPT ); Tue, 11 Nov 2008 13:47:28 -0500 Received: from gw.goop.org ([64.81.55.164]:57420 "EHLO mail.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751750AbYKKSr1 (ORCPT ); Tue, 11 Nov 2008 13:47:27 -0500 Message-ID: <4919D33C.3030101@goop.org> Date: Tue, 11 Nov 2008 10:47:24 -0800 From: Jeremy Fitzhardinge User-Agent: Thunderbird 2.0.0.17 (X11/20081009) MIME-Version: 1.0 To: Takashi Iwai CC: Isaku Yamahata , Sam Ravnborg , Tony Luck , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix section type conflict in arch/ia64/xen/xen_pv_ops.c References: <49133E11.8050607@goop.org> <20081106214848.GA3579@uranus.ravnborg.org> <20081111081552.GA10955%yamahata@valinux.co.jp> <20081111085617.GD10955%yamahata@valinux.co.jp> <4919C43F.3030009@goop.org> In-Reply-To: X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Takashi Iwai wrote: > At Tue, 11 Nov 2008 09:43:27 -0800, > Jeremy Fitzhardinge wrote: > >> Isaku Yamahata wrote: >> >>> Here is. >>> >>> __initdata and const cannot be always a happy pair and >>> x86 xen has the potential issue. >>> This patch simply removes const from data with __initdata >>> under arch/x86/xen/. >>> >>> >> No, I think the proper fix is to use __initconst. >> > > The problem is that it depends on gcc version which section it goes. > Thus __initconst could break some gcc versions as well. > Why? __initconst explicitly puts it in .init.rodata. J