* Dell Wireless 365 requires reset quirk @ 2008-11-04 16:24 Tim Gardner 2008-11-11 22:57 ` Andrew Morton 0 siblings, 1 reply; 5+ messages in thread From: Tim Gardner @ 2008-11-04 16:24 UTC (permalink / raw) To: marcel; +Cc: linux-bluetooth, linux-kernel >From 931ccb629d739aa563347a4e866bc26107e6b545 Mon Sep 17 00:00:00 2001 From: Tim Gardner <tim.gardner@canonical.com> Date: Tue, 4 Nov 2008 09:18:06 -0700 Subject: [PATCH] Dell Wireless 365 needs BTUSB_RESET quirk. OriginalAuthor: Mario Limonciello <mario_limonciello@dell.com> Signed-off-by: Tim Gardner <tim.gardner@canonical.com> Cc: stable@kernel.org --- drivers/bluetooth/btusb.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index af472e0..051b758 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -125,6 +125,9 @@ static struct usb_device_id blacklist_table[] = { /* Dell laptop with Broadcom chip */ { USB_DEVICE(0x413c, 0x8126), .driver_info = BTUSB_RESET | BTUSB_WRONG_SCO_MTU }, + /* Dell Wireless 365 */ + { USB_DEVICE(0x413c, 0x8160), .driver_info = BTUSB_RESET }, + /* Dell Wireless 370 */ { USB_DEVICE(0x413c, 0x8156), .driver_info = BTUSB_RESET | BTUSB_WRONG_SCO_MTU }, -- 1.5.6.3 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: Dell Wireless 365 requires reset quirk 2008-11-04 16:24 Dell Wireless 365 requires reset quirk Tim Gardner @ 2008-11-11 22:57 ` Andrew Morton 2008-11-11 23:41 ` Mario Limonciello 2008-11-14 0:59 ` Tim Gardner 0 siblings, 2 replies; 5+ messages in thread From: Andrew Morton @ 2008-11-11 22:57 UTC (permalink / raw) To: Tim Gardner; +Cc: marcel, linux-bluetooth, linux-kernel On Tue, 4 Nov 2008 09:24:48 -0700 (MST) timg@tpi.com (Tim Gardner) wrote: > >From 931ccb629d739aa563347a4e866bc26107e6b545 Mon Sep 17 00:00:00 2001 > From: Tim Gardner <tim.gardner@canonical.com> > Date: Tue, 4 Nov 2008 09:18:06 -0700 > Subject: [PATCH] Dell Wireless 365 needs BTUSB_RESET quirk. > OriginalAuthor: Mario Limonciello <mario_limonciello@dell.com> > > Signed-off-by: Tim Gardner <tim.gardner@canonical.com> > Cc: stable@kernel.org > --- > drivers/bluetooth/btusb.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > index af472e0..051b758 100644 > --- a/drivers/bluetooth/btusb.c > +++ b/drivers/bluetooth/btusb.c > @@ -125,6 +125,9 @@ static struct usb_device_id blacklist_table[] = { > /* Dell laptop with Broadcom chip */ > { USB_DEVICE(0x413c, 0x8126), .driver_info = BTUSB_RESET | BTUSB_WRONG_SCO_MTU }, > > + /* Dell Wireless 365 */ > + { USB_DEVICE(0x413c, 0x8160), .driver_info = BTUSB_RESET }, > + > /* Dell Wireless 370 */ > { USB_DEVICE(0x413c, 0x8156), .driver_info = BTUSB_RESET | BTUSB_WRONG_SCO_MTU }, > I shall assume that this patch was authored by Mario. This should have been communicated by adding his From: line right at the top of the changelog. Mario's signed-off-by: is absent, but that is tolerable because we have yours. The (absent) changelog fails to explain what effect this patch has. _why_ does this driver need this quirk? As it stands, there is insufficient information here for making 2.6.28-vs-2.6.29 decisions, let alone 2.6.27.x, 2.6.26.x, etc. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Dell Wireless 365 requires reset quirk 2008-11-11 22:57 ` Andrew Morton @ 2008-11-11 23:41 ` Mario Limonciello 2008-11-14 0:59 ` Tim Gardner 1 sibling, 0 replies; 5+ messages in thread From: Mario Limonciello @ 2008-11-11 23:41 UTC (permalink / raw) To: Andrew Morton; +Cc: Tim Gardner, marcel, linux-bluetooth, linux-kernel [-- Attachment #1: Type: text/plain, Size: 876 bytes --] Andrew Morton wrote: > On Tue, 4 Nov 2008 09:24:48 -0700 (MST) > timg@tpi.com (Tim Gardner) wrote: > > > > I shall assume that this patch was authored by Mario. This should have > been communicated by adding his From: line right at the top of the > changelog. Mario's signed-off-by: is absent, but that is tolerable > because we have yours. > > The (absent) changelog fails to explain what effect this patch has. > _why_ does this driver need this quirk? > > As it stands, there is insufficient information here for making > 2.6.28-vs-2.6.29 decisions, let alone 2.6.27.x, 2.6.26.x, etc. > Hi Andrew: This patch causes the BT365 to be reset when the driver is loaded. Without it, you won't be able to connect to other devices or scan for devices. Regards -- Mario Limonciello *Dell | Linux Engineering* mario_limonciello@dell.com [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 260 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Dell Wireless 365 requires reset quirk 2008-11-11 22:57 ` Andrew Morton 2008-11-11 23:41 ` Mario Limonciello @ 2008-11-14 0:59 ` Tim Gardner 2008-11-30 10:33 ` Marcel Holtmann 1 sibling, 1 reply; 5+ messages in thread From: Tim Gardner @ 2008-11-14 0:59 UTC (permalink / raw) To: Andrew Morton; +Cc: marcel, linux-bluetooth, linux-kernel, Mario Limonciello [-- Attachment #1: Type: text/plain, Size: 1779 bytes --] Andrew Morton wrote: > On Tue, 4 Nov 2008 09:24:48 -0700 (MST) > timg@tpi.com (Tim Gardner) wrote: > >> >From 931ccb629d739aa563347a4e866bc26107e6b545 Mon Sep 17 00:00:00 2001 >> From: Tim Gardner <tim.gardner@canonical.com> >> Date: Tue, 4 Nov 2008 09:18:06 -0700 >> Subject: [PATCH] Dell Wireless 365 needs BTUSB_RESET quirk. >> OriginalAuthor: Mario Limonciello <mario_limonciello@dell.com> >> >> Signed-off-by: Tim Gardner <tim.gardner@canonical.com> >> Cc: stable@kernel.org >> --- >> drivers/bluetooth/btusb.c | 3 +++ >> 1 files changed, 3 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c >> index af472e0..051b758 100644 >> --- a/drivers/bluetooth/btusb.c >> +++ b/drivers/bluetooth/btusb.c >> @@ -125,6 +125,9 @@ static struct usb_device_id blacklist_table[] = { >> /* Dell laptop with Broadcom chip */ >> { USB_DEVICE(0x413c, 0x8126), .driver_info = BTUSB_RESET | BTUSB_WRONG_SCO_MTU }, >> >> + /* Dell Wireless 365 */ >> + { USB_DEVICE(0x413c, 0x8160), .driver_info = BTUSB_RESET }, >> + >> /* Dell Wireless 370 */ >> { USB_DEVICE(0x413c, 0x8156), .driver_info = BTUSB_RESET | BTUSB_WRONG_SCO_MTU }, >> > > I shall assume that this patch was authored by Mario. This should have > been communicated by adding his From: line right at the top of the > changelog. Mario's signed-off-by: is absent, but that is tolerable > because we have yours. > > The (absent) changelog fails to explain what effect this patch has. > _why_ does this driver need this quirk? > > As it stands, there is insufficient information here for making > 2.6.28-vs-2.6.29 decisions, let alone 2.6.27.x, 2.6.26.x, etc. > Is this better (aside from being an attachment) ? rtg -- Tim Gardner tim.gardner@canonical.com [-- Attachment #2: 0001--bluetooth-Dell-Wireless-365-needs-BTUSB_RESET-qui.patch --] [-- Type: text/x-patch, Size: 1184 bytes --] >From 8da2a85810aa0fb5abbc93d15482846af5d60669 Mon Sep 17 00:00:00 2001 From: Mario Limonciello <mario_limonciello@dell.com> Date: Tue, 4 Nov 2008 09:18:06 -0700 Subject: [PATCH] bluetooth: Dell Wireless 365 needs BTUSB_RESET quirk. This patch causes the BT365 to be reset when the driver is loaded. Without it, you won't be able to connect to other devices or scan for devices. Signed-off-by: Mario Limonciello <mario_limonciello@dell.com> Signed-off-by: Tim Gardner <tim.gardner@canonical.com> Cc: stable@kernel.org --- drivers/bluetooth/btusb.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index af472e0..051b758 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -125,6 +125,9 @@ static struct usb_device_id blacklist_table[] = { /* Dell laptop with Broadcom chip */ { USB_DEVICE(0x413c, 0x8126), .driver_info = BTUSB_RESET | BTUSB_WRONG_SCO_MTU }, + /* Dell Wireless 365 */ + { USB_DEVICE(0x413c, 0x8160), .driver_info = BTUSB_RESET }, + /* Dell Wireless 370 */ { USB_DEVICE(0x413c, 0x8156), .driver_info = BTUSB_RESET | BTUSB_WRONG_SCO_MTU }, -- 1.5.6.3 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: Dell Wireless 365 requires reset quirk 2008-11-14 0:59 ` Tim Gardner @ 2008-11-30 10:33 ` Marcel Holtmann 0 siblings, 0 replies; 5+ messages in thread From: Marcel Holtmann @ 2008-11-30 10:33 UTC (permalink / raw) To: Tim Gardner Cc: Andrew Morton, linux-bluetooth, linux-kernel, Mario Limonciello Hi Tim, > >> >From 931ccb629d739aa563347a4e866bc26107e6b545 Mon Sep 17 00:00:00 2001 > >> From: Tim Gardner <tim.gardner@canonical.com> > >> Date: Tue, 4 Nov 2008 09:18:06 -0700 > >> Subject: [PATCH] Dell Wireless 365 needs BTUSB_RESET quirk. > >> OriginalAuthor: Mario Limonciello <mario_limonciello@dell.com> > >> > >> Signed-off-by: Tim Gardner <tim.gardner@canonical.com> > >> Cc: stable@kernel.org > >> --- > >> drivers/bluetooth/btusb.c | 3 +++ > >> 1 files changed, 3 insertions(+), 0 deletions(-) > >> > >> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > >> index af472e0..051b758 100644 > >> --- a/drivers/bluetooth/btusb.c > >> +++ b/drivers/bluetooth/btusb.c > >> @@ -125,6 +125,9 @@ static struct usb_device_id blacklist_table[] = { > >> /* Dell laptop with Broadcom chip */ > >> { USB_DEVICE(0x413c, 0x8126), .driver_info = BTUSB_RESET | BTUSB_WRONG_SCO_MTU }, > >> > >> + /* Dell Wireless 365 */ > >> + { USB_DEVICE(0x413c, 0x8160), .driver_info = BTUSB_RESET }, > >> + > >> /* Dell Wireless 370 */ > >> { USB_DEVICE(0x413c, 0x8156), .driver_info = BTUSB_RESET | BTUSB_WRONG_SCO_MTU }, > >> > > > > I shall assume that this patch was authored by Mario. This should have > > been communicated by adding his From: line right at the top of the > > changelog. Mario's signed-off-by: is absent, but that is tolerable > > because we have yours. > > > > The (absent) changelog fails to explain what effect this patch has. > > _why_ does this driver need this quirk? > > > > As it stands, there is insufficient information here for making > > 2.6.28-vs-2.6.29 decisions, let alone 2.6.27.x, 2.6.26.x, etc. > > > > Is this better (aside from being an attachment) ? the patch will no longer be needed. I am making HCI Reset the default and only letting the old drivers quirk a NO_RESET. Regards Marcel ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-11-30 10:33 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2008-11-04 16:24 Dell Wireless 365 requires reset quirk Tim Gardner 2008-11-11 22:57 ` Andrew Morton 2008-11-11 23:41 ` Mario Limonciello 2008-11-14 0:59 ` Tim Gardner 2008-11-30 10:33 ` Marcel Holtmann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox