From: "H. Peter Anvin" <hpa@zytor.com>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: Ingo Molnar <mingo@elte.hu>,
Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] x86: ia32_signal: remove unnecessary padding
Date: Wed, 12 Nov 2008 09:12:15 -0800 [thread overview]
Message-ID: <491B0E6F.2010301@zytor.com> (raw)
In-Reply-To: <18714.52512.213371.33245@harpo.it.uu.se>
Mikael Pettersson wrote:
> It does cause each signal delivery to leak 2 uninitialised
> kernel bytes to the end of retcode[], which seems unnecessary.
Not just unnecessary, it is a huge no-no for security.
NAK on this.
-hpa
next prev parent reply other threads:[~2008-11-12 17:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 3:09 [PATCH 1/2] x86: signal_32: introduce retcode and rt_retcode Hiroshi Shimamoto
2008-11-12 3:11 ` [PATCH 2/2] x86: ia32_signal: remove unnecessary padding Hiroshi Shimamoto
2008-11-12 11:29 ` Ingo Molnar
2008-11-12 12:33 ` Mikael Pettersson
2008-11-12 17:12 ` H. Peter Anvin [this message]
2008-11-12 18:02 ` Hiroshi Shimamoto
2008-11-12 18:12 ` H. Peter Anvin
2008-11-13 8:45 ` Mikael Pettersson
2008-11-13 17:38 ` H. Peter Anvin
2008-11-12 12:56 ` Andi Kleen
2008-11-12 18:34 ` Hiroshi Shimamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491B0E6F.2010301@zytor.com \
--to=hpa@zytor.com \
--cc=h-shimamoto@ct.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@it.uu.se \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox