Re: [RFC][mm] [PATCH 3/4] Memory cgroup hierarchical reclaim (v3)

KAMEZAWA Hiroyuki
2008-11-12T06:13:24Z

On Wed, 12 Nov 2008 11:40:13 +0530
Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>
> I think of it as easy to update - as in the modularity, you can plug out
> hierarchical reclaim easily and implement your own hierarchical reclaim.
>
When I do so, I'll rewrite all, again.

> > Can you make this code iterative rather than recursive ?
> >
> > I don't like this kind of recursive call with complexed lock/unlock.
>
> I tried an iterative version, which ended up looking very ugly. I think the
> recursive version is easier to understand. What we do is a DFS walk - pretty
> standard algorithm.
>
But recursive one is not good for search-and-try algorithm.

Thanks,
-Kame