From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Ben Dooks <ben-linux@fluff.org>, Pierre Ossman <drzeus@drzeus.cx>
Cc: Haavard Skinnemoen <hskinnemoen@atmel.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
kernel@avr32linux.org
Subject: Re: [PATCH] mmc: atmel-mci: move atmel-mci.h file to include/linux
Date: Thu, 13 Nov 2008 15:43:34 +0100 [thread overview]
Message-ID: <491C3D16.1050501@atmel.com> (raw)
In-Reply-To: <20081113134818.GA9161@fluff.org.uk>
Ben Dooks :
> On Thu, Nov 13, 2008 at 12:14:13PM +0100, Nicolas Ferre wrote:
>> Needed to use the atmel-mci driver in a architecture
>> independent manner.
>>
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>> ---
>> arch/avr32/boards/atngw100/setup.c | 2 +-
>> arch/avr32/boards/atstk1000/atstk1002.c | 2 +-
>> arch/avr32/boards/atstk1000/atstk1003.c | 2 +-
>> arch/avr32/boards/atstk1000/atstk1004.c | 2 +-
>> arch/avr32/include/asm/atmel-mci.h | 39 ------
>> arch/avr32/mach-at32ap/at32ap700x.c | 2 +-
>> drivers/mmc/host/atmel-mci.c | 2 +-
>> include/linux/atmel-mci.h | 39 ++++++
>
> Would people object to putting this in include/linux/mmc/atmel.h
> to avoid making include/linux abound with device/subsystem/machine
> specific header files?
I tend to agree *but* it seems that header files in include/linux/mmc
are mostly sd/mmc subsystem core files (I mean, not driver ones).
Although, a bunch of atmel-a_driver.h files are already in include/linux...
Pierre, a comment ?
Regards,
--
Nicolas Ferre
next prev parent reply other threads:[~2008-11-13 14:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 11:14 [PATCH] mmc: atmel-mci: move atmel-mci.h file to include/linux Nicolas Ferre
2008-11-13 11:26 ` Haavard Skinnemoen
2008-11-13 13:48 ` Ben Dooks
2008-11-13 14:43 ` Nicolas Ferre [this message]
2008-11-19 18:36 ` Pierre Ossman
[not found] ` <b0c88b10811192207oe65e02fg91ec6476b49564ba@mail.gmail.com>
2008-11-20 6:20 ` Fwd: " Antonio R. Costa
2008-11-20 14:25 ` Nicolas Ferre
2008-11-20 14:34 ` Haavard Skinnemoen
2008-11-20 14:59 ` Nicolas Ferre
2008-11-22 18:41 ` Pierre Ossman
2009-01-05 16:23 ` Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491C3D16.1050501@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=ben-linux@fluff.org \
--cc=drzeus@drzeus.cx \
--cc=hskinnemoen@atmel.com \
--cc=kernel@avr32linux.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox