Re: [PATCH 25 of 38] xen mtrr: Add mtrr_ops support for Xen mtrr

[Jeremy Fitzhardinge <jeremy@goop.org>]

Mark McLoughlin wrote:
> On Thu, 2008-11-13 at 11:10 -0800, Jeremy Fitzhardinge wrote:
>
>   
>> diff --git a/arch/x86/kernel/cpu/mtrr/xen.c b/arch/x86/kernel/cpu/mtrr/xen.c
>> new file mode 100644
>> --- /dev/null
>> +++ b/arch/x86/kernel/cpu/mtrr/xen.c
>> @@ -0,0 +1,59 @@
>>     
> ...
>   
>> +
>> +/* DOM0 TODO: Need to fill in the remaining mtrr methods to have full
>> + * working userland mtrr support. */
>> +static struct mtrr_ops xen_mtrr_ops = {
>> +	.vendor            = X86_VENDOR_UNKNOWN,
>> +//	.set               = xen_set_mtrr,
>> +//	.get               = xen_get_mtrr,
>> +	.get_free_region   = generic_get_free_region,
>> +//	.validate_add_page = xen_validate_add_page,
>> +	.have_wrcomb       = positive_have_wrcomb,
>> +	.use_intel_if	   = 0,
>> +	.num_var_ranges	   = xen_num_var_ranges,
>> +};
>>     
>
> ...
>
> I'm vague on the details now, but looking back at the dom0 patch set
> here:
>
> http://git.et.redhat.com/?p=linux-2.6-dom0-pvops.git;a=shortlog;h=55abc194080b5cf31cd66f5e35e8e5c5af2aa927
>
> I see we did have a bunch more mtrr work e.g. fixing the TODO above:
>
> http://git.et.redhat.com/?p=linux-2.6-dom0-pvops.git;a=commitdiff;h=93f779bf3d79f28d0933bfbc53f7b8c5b6496081
>   

Yes, the mtrr changes are incomplete.  I started on them as much as 
necessary to get things booting, and then left the rest to revisit.  
It's not a particularly pretty part of the kernel, and so I was hoping 
some magic beautification fairy would visit it before I needed to touch 
it more...

    J