From: Artem Bityutskiy <dedekind@yandex.ru>
To: Eric Paris <eparis@redhat.com>
Cc: linux-kernel@vger.kernel.org, sct@redhat.com,
akpm@linux-foundation.org, adilger@sun.com, tytso@mit.edu,
linux-ext4@vger.kernel.org, dedekind@infradead.org,
ext-adrian.hunter@nokia.com, linux-mtd@lists.infradead.org,
dushistov@mail.ru, jmorris@namei.org
Subject: Re: [PATCH] filesystems: use has_capability_noaudit interface for reserved blocks checks
Date: Fri, 14 Nov 2008 09:55:53 +0200 [thread overview]
Message-ID: <491D2F09.3070104@yandex.ru> (raw)
In-Reply-To: <1226430769.3353.5.camel@localhost.localdomain>
Eric Paris wrote:
> ext[2,3,4], ufs, and ubifs all check for CAP_SYS_RESOURCE to determine
> if they should allow reserved blocks to be used. A process not having
> this capability is not failing some security decision and should not be
> audited. Thus move to using has_capability_noaudit.
>
> Signed-off-by: Eric Paris <eparis@redhat.com>
> ---
UBIFS part looks OK, as long as the whole idea of the patch is right, which
I have not checked, but assume it is.
The only question is are you sure exporting 'cap_capable()' is relevant
to this patch? You do not seem to call it directly.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2008-11-14 8:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-11 19:12 [PATCH] filesystems: use has_capability_noaudit interface for reserved blocks checks Eric Paris
2008-11-13 0:19 ` Mingming Cao
2008-11-13 22:53 ` Andrew Morton
2008-11-13 23:07 ` Theodore Tso
2008-11-14 7:55 ` Artem Bityutskiy [this message]
2008-11-14 15:36 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491D2F09.3070104@yandex.ru \
--to=dedekind@yandex.ru \
--cc=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=dedekind@infradead.org \
--cc=dushistov@mail.ru \
--cc=eparis@redhat.com \
--cc=ext-adrian.hunter@nokia.com \
--cc=jmorris@namei.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=sct@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox