public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86: fix sparse warnings in ptrace.c
@ 2008-11-14 21:28 Simon Arlott
  0 siblings, 0 replies; only message in thread
From: Simon Arlott @ 2008-11-14 21:28 UTC (permalink / raw)
  To: Linux Kernel Mailing List, trivial, Ingo Molnar

arch/x86/kernel/ptrace.c:634:32: error: incompatible types for operation (*)
arch/x86/kernel/ptrace.c:634:32:    left side has type unsigned char static [unsigned] [toplevel] sizeof_field
arch/x86/kernel/ptrace.c:634:32:    right side has type bad type enum bts_field field
arch/x86/kernel/ptrace.c:634:7: error: invalid assignment

arch/x86/kernel/ptrace.c:640:32: error: incompatible types for operation (*)
arch/x86/kernel/ptrace.c:640:32:    left side has type unsigned char static [unsigned] [toplevel] sizeof_field
arch/x86/kernel/ptrace.c:640:32:    right side has type bad type enum bts_field field
arch/x86/kernel/ptrace.c:640:7: error: invalid assignment

Signed-off-by: Simon Arlott <simon@fire.lp0.eu>
---
 arch/x86/kernel/ptrace.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c
index 0a6d8c1..662a400 100644
--- a/arch/x86/kernel/ptrace.c
+++ b/arch/x86/kernel/ptrace.c
@@ -631,13 +631,13 @@ enum bts_field {
 
 static inline unsigned long bts_get(const char *base, enum bts_field field)
 {
-	base += (bts_cfg.sizeof_field * field);
+	base += (bts_cfg.sizeof_field * (unsigned char)field);
 	return *(unsigned long *)base;
 }
 
 static inline void bts_set(char *base, enum bts_field field, unsigned long val)
 {
-	base += (bts_cfg.sizeof_field * field);;
+	base += (bts_cfg.sizeof_field * (unsigned char)field);
 	(*(unsigned long *)base) = val;
 }
 
-- 
1.6.0.3

-- 
Simon Arlott

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2008-11-14 21:28 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-14 21:28 [PATCH] x86: fix sparse warnings in ptrace.c Simon Arlott

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox