From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2/5] x86: ia32_signal: introduce COPY_SEG_STRICT
Date: Fri, 14 Nov 2008 19:26:39 -0800 [thread overview]
Message-ID: <491E416F.5040703@ct.jp.nec.com> (raw)
In-Reply-To: <491E4101.7010405@ct.jp.nec.com>
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Impact: cleanup
Introduce COPY_SEG_STRICT for ia32_restore_sigcontext().
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
---
arch/x86/ia32/ia32_signal.c | 12 ++++++++----
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/arch/x86/ia32/ia32_signal.c b/arch/x86/ia32/ia32_signal.c
index a28790a..f74178e 100644
--- a/arch/x86/ia32/ia32_signal.c
+++ b/arch/x86/ia32/ia32_signal.c
@@ -201,6 +201,12 @@ struct rt_sigframe
err |= __get_user(regs->x, &sc->x); \
}
+#define COPY_SEG_STRICT(seg) { \
+ unsigned short tmp; \
+ err |= __get_user(tmp, &sc->seg); \
+ regs->seg = tmp | 3; \
+}
+
#define RELOAD_SEG(seg,mask) \
{ unsigned int cur; \
unsigned short pre; \
@@ -246,10 +252,8 @@ static int ia32_restore_sigcontext(struct pt_regs *regs,
COPY(dx); COPY(cx); COPY(ip);
/* Don't touch extended registers */
- err |= __get_user(regs->cs, &sc->cs);
- regs->cs |= 3;
- err |= __get_user(regs->ss, &sc->ss);
- regs->ss |= 3;
+ COPY_SEG_STRICT(cs);
+ COPY_SEG_STRICT(ss);
err |= __get_user(tmpflags, &sc->flags);
regs->flags = (regs->flags & ~FIX_EFLAGS) | (tmpflags & FIX_EFLAGS);
--
1.5.6
next prev parent reply other threads:[~2008-11-15 3:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-15 3:24 [PATCH 1/5] x86: ia32_signal: cleanup macro COPY Hiroshi Shimamoto
2008-11-15 3:26 ` Hiroshi Shimamoto [this message]
2008-11-15 17:11 ` [PATCH 2/5] x86: ia32_signal: introduce COPY_SEG_STRICT Américo Wang
2008-11-17 18:03 ` Hiroshi Shimamoto
2008-11-15 3:27 ` [PATCH 3/5] x86: ia32_signal: cleanup macro RELOAD_SEG Hiroshi Shimamoto
2008-11-15 17:15 ` Américo Wang
2008-11-15 3:28 ` [PATCH 4/5] x86: ia32_signal: remove using temporary variable Hiroshi Shimamoto
2008-11-15 17:22 ` Américo Wang
2008-11-17 18:09 ` Hiroshi Shimamoto
2008-11-15 3:28 ` [PATCH 5/5] x86: ia32_signal: change order of storing in setup_sigcontext() Hiroshi Shimamoto
2008-11-15 17:25 ` Américo Wang
2008-11-17 18:20 ` Hiroshi Shimamoto
2008-11-15 17:06 ` [PATCH 1/5] x86: ia32_signal: cleanup macro COPY Américo Wang
2008-11-17 17:57 ` Hiroshi Shimamoto
2008-11-17 23:44 ` [PATCH v2 " Hiroshi Shimamoto
2008-11-17 23:47 ` [PATCH v2 2/5] x86: ia32_signal: introduce COPY_SEG_STRICT Hiroshi Shimamoto
2008-11-17 23:52 ` H. Peter Anvin
2008-11-18 0:09 ` Hiroshi Shimamoto
2008-11-18 15:56 ` Ingo Molnar
2008-11-17 23:47 ` [PATCH v2 3/5] x86: ia32_signal: cleanup macro RELOAD_SEG Hiroshi Shimamoto
2008-11-17 23:48 ` [PATCH v2 4/5] x86: ia32_signal: remove using temporary variable Hiroshi Shimamoto
2008-11-17 23:49 ` [PATCH v2 5/5] x86: ia32_signal: change order of storing in setup_sigcontext() Hiroshi Shimamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491E416F.5040703@ct.jp.nec.com \
--to=h-shimamoto@ct.jp.nec.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox