From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755957AbYKOMq3 (ORCPT ); Sat, 15 Nov 2008 07:46:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751878AbYKOMqT (ORCPT ); Sat, 15 Nov 2008 07:46:19 -0500 Received: from outbound-mail-33.bluehost.com ([69.89.18.153]:36159 "HELO outbound-mail-33.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751319AbYKOMqS (ORCPT ); Sat, 15 Nov 2008 07:46:18 -0500 X-Greylist: delayed 400 seconds by postgrey-1.27 at vger.kernel.org; Sat, 15 Nov 2008 07:46:18 EST DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=uniscape.net; h=Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-Identified-User; b=Q9V8e2qkcxDaqItc5JXXLbEyomuC84bQUp7HQauYtjqBmTjc399WLwH9g0VwAeB4OMlDrwequvGQvEDzhnKuKGJ5QMV8dYmrnQZcveyal56H4CyR9BG5S1PndDfdFCSQ; Message-ID: <491EC2DF.2070704@uniscape.net> Date: Sat, 15 Nov 2008 20:38:55 +0800 From: Yu Zhao User-Agent: Thunderbird 2.0.0.17 (X11/20080914) MIME-Version: 1.0 To: Matthew Wilcox CC: "Zhao, Yu" , "linux-pci@vger.kernel.org" , Jesse Barnes , Randy Dunlap , Grant Grundler , Alex Chiang , Roland Dreier , Greg KH , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "virtualization@lists.linux-foundation.org" Subject: Re: [PATCH 6/6 v3] PCI: document the change References: <20081001160706.GI13822@parisc-linux.org> In-Reply-To: <20081001160706.GI13822@parisc-linux.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Identified-User: {2990:host272.hostmonster.com:uniscape:uniscape.net} {sentby:smtp auth 58.41.76.172 authed with yu.zhao@uniscape.net} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matthew Wilcox wrote: > On Sat, Sep 27, 2008 at 04:28:45PM +0800, Zhao, Yu wrote: >> +To register SR-IOV service, Physical Function device driver needs to call: >> + int pci_iov_register(struct pci_dev *dev, >> + int (*notify)(struct pci_dev *, u32), char **entries) > > I think a better interface would put the 'notify' into the struct > pci_driver. That would make 'notify' a bad name .... how about > 'virtual'? There's also no documentation for the second parameter to > 'notify'. Yes, putting the callback function to the 'pci_driver' is better. Looks like the 'virtual' is not very descriptive (and it's a adj. while other callbacks are verb). Any other candidates? Thanks, Yu