Re: [PATCH v11 18/19] KVM: s390: pv: avoid export before import if possible

Janosch Frank
2022-06-20T09:56:47Z

On 6/3/22 08:56, Claudio Imbrenda wrote:
> If the appropriate UV feature bit is set, there is no need to perform
> an export before import.
>
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> ---
> arch/s390/kernel/uv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c
> index 02aca3c5dce1..c18c3d6a4314 100644
> --- a/arch/s390/kernel/uv.c
> +++ b/arch/s390/kernel/uv.c
> @@ -249,6 +249,8 @@ static int make_secure_pte(pte_t *ptep, unsigned long addr,
> */
> static bool should_export_before_import(struct uv_cb_header *uvcb, struct mm_struct *mm)
> {
> + if (test_bit_inv(BIT_UV_FEAT_MISC, &uv_info.uv_feature_indications))
> + return false;

This needs a comment explaining, that this is only an option for shared
pages.

> if (uvcb->cmd == UVC_CMD_UNPIN_PAGE_SHARED)
> return false;
> return atomic_read(&mm->context.protected_count) > 1;