From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: akpm@linux-foundation.org, kosaki.motohiro@jp.fujitsu.com,
kamezawa.hiroyu@jp.fujitsu.com, laijs@cn.fujitsu.com,
arjan@infradead.org, airlied@gmail.com, menage@google.com,
jens.axboe@oracle.com, jack@suse.cz, jes@sgi.com,
linux-kernel@vger.kernel.org, dada1@cosmosbay.com,
adobriyan@gmail.com
Subject: Re: [PATCH 1/7] mm: introduce simple_malloc()/simple_free()
Date: Mon, 17 Nov 2008 13:54:03 +0530 [thread overview]
Message-ID: <49212A23.3000209@linux.vnet.ibm.com> (raw)
In-Reply-To: <20081116.231555.190117597.davem@davemloft.net>
David Miller wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> Date: Sun, 16 Nov 2008 23:13:01 -0800
>
>> In fact it's not immediately clear why __vmalloc() takes a gfp_t
>> argument either?
>
> Probably for things like GFP_DMA32, GFP_HIGHMEM, et al.
>
vmalloc() hides away GFP_DMA32 and hard codes gfp_mask to GFP_KERNEL |
__GFP_HIGHMEM. __vmalloc() lies like Andrew mentioned. For the use cases
mentioned in this thread, we don't really care about GFP_DMA32 (or do we?).
I would prefer to avoid passing the gfp_mask and call the API something like
blocking_vkmalloc() and blocking_vkzalloc() or something better.
--
Balbir
next prev parent reply other threads:[~2008-11-17 8:24 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-16 4:33 [PATCH 1/7] mm: introduce simple_malloc()/simple_free() Lai Jiangshan
2008-11-16 4:49 ` Alexey Dobriyan
2008-11-16 8:14 ` David Miller
2008-11-16 18:42 ` KOSAKI Motohiro
2008-11-16 4:52 ` Arjan van de Ven
2008-11-16 5:03 ` Andrew Morton
2008-11-16 5:35 ` Lai Jiangshan
2008-11-16 5:47 ` Andrew Morton
2008-11-16 5:53 ` Arjan van de Ven
2008-11-16 6:08 ` Eric Dumazet
2008-11-16 8:23 ` David Miller
2008-11-16 8:21 ` David Miller
2008-11-16 8:19 ` David Miller
2008-11-16 18:57 ` Arjan van de Ven
2008-11-16 21:39 ` Dave Airlie
2008-11-16 21:51 ` Arjan van de Ven
2008-11-16 22:42 ` Dave Airlie
2008-11-17 2:08 ` Lai Jiangshan
2008-11-17 4:53 ` Balbir Singh
2008-11-17 5:25 ` KAMEZAWA Hiroyuki
2008-11-17 6:43 ` KOSAKI Motohiro
2008-11-17 7:13 ` Andrew Morton
2008-11-17 7:15 ` David Miller
2008-11-17 8:10 ` KOSAKI Motohiro
2008-11-17 8:24 ` Balbir Singh [this message]
2008-11-18 4:39 ` Nick Piggin
2008-11-18 5:16 ` Lai Jiangshan
2008-11-17 4:46 ` Balbir Singh
2008-11-17 4:43 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49212A23.3000209@linux.vnet.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=adobriyan@gmail.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=jack@suse.cz \
--cc=jens.axboe@oracle.com \
--cc=jes@sgi.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox