Re: [PATCH] vmscan: fix get_scan_ratio comment

Linus Torvalds
2008-11-17T17:36:23Z

Grr. Don't use attachments. Now I can't sanely reply and quote things
with a sane default setting (yes, I could set "include attachements in
reply", but that is _not_ a sane default setting, and anybody who claims
it is is a moron).

Why don't people learn?

Anyway, without quoting, the thing is - your fix isn't any better. The
more interesting part is how the fractions get combined, and that is
indeed approximately "anon% = anon / (anon + file)".

So you in many ways made the comment worse. It wasn't good before, but
it's still not good, and now it comments on the part that isn't even
interesting (ie it comments the _trivial_ fractional part)

Linus