From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752438AbdIVRlA (ORCPT <rfc822;w@1wt.eu>);
        Fri, 22 Sep 2017 13:41:00 -0400
Received: from mout.web.de ([212.227.17.11]:58549 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752276AbdIVRk6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 22 Sep 2017 13:40:58 -0400
Subject: Re: [media] spca500: Use common error handling code in
 spca500_synch310()
To: Julia Lawall <julia.lawall@lip6.fr>, linux-media@vger.kernel.org
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <d496ca24-1725-768b-5e55-4e45097cb77d@users.sourceforge.net>
 <alpine.DEB.2.20.1709221908230.3170@hadrien>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <4921ea61-49cd-4071-e636-c199daddec8e@users.sourceforge.net>
Date: Fri, 22 Sep 2017 19:40:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1709221908230.3170@hadrien>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:QojKmfpTFMeWMGGIi4e6dMVtwutfejXuAJQODAx47cKKaztTHSX
 U9ZEITktnV7KqwfaohVdcjFJbW7dhm8wNwXkUHfX0y9sQM/xX/nuroHMi3uDVBKXef24WpU
 K7kW81EOaUP3MuCt5N7gAZKZfWTY7OetSMzet9wEdBvkJ3I/Puk/yGgNDLsVq6qNiaKbAzU
 ta084kA5EzR2n2PQNUoZQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:w6+53pcI1Bw=:wm5+4ingrPy+rmkntRq/ga
 7Ps1vw+9jPHqD6WUa+Mjjy5QdAHQfaKyIzu6iyMno5TFN8S50RxnGWBqirNVlTSbjxs1vB1L2
 fxKS9p6J8WzdMIkchGW6JJ3AXFfmPZW8XPPvqOYT1Hvkqrjg5zs+GJLd1voV2K/nTuTSOGv+w
 EFG3wKfXdi2EIWUoqtr1wA2hF9pfjfYfIul3lwo8v7JgAIK2lrpFIfWcsp3ZtxYH6sOz4TXjm
 v9kGaB+TW2zfpkSDUda2+QmA5D2h1C6ki/GJf7wKexol9qrEUhq1POBwDg0UD41CdVdhpiaW5
 QXp+2CIWgyVSuEmMybOIftTYAOcGtTvhus/40xRxupZdYC63HrhGfmfQybQqzMGsdL8rtec/g
 IuU3URYw88gVNbHyz6bibC6WxCdvW4ZcspZI11bcMkhWbRipHI98qJYNAyGOrrlD8W04llG8i
 yWoqmw8EzgqwQeK6SrvTmzLPoRWZz4f/hD5eQ9smdyS4cfVr0na04wQ5RjP/HLlCNEo5jMIlx
 y+xDB2l8i7NEZfKbd1FKTr0rM6LO4UZp6oAULP3Xm4Yph955zy2TPno2AfvrnMVieXvVBFSmp
 kN+mlmR7umye/FW03kXfrvuYh7trTFcE/XY79rE+kFUd2fyPX4tlQPJxrBr2z6O6ChN1rbk4k
 F3rKYUJMHn/da/PLdGh+uaiqhoveN0cpFSPSymCkwXVObjA+7KQ7pbqQKhYJCctm8HWsSPkQL
 dbwdq54DQJeMAhq8f4RakumBFqbleBGDr0Y9cvFNWoGioOp6jylCBytELi7nXmezd4JNk5iCA
 2+8xw9k9Ax+elxRJ58CLHO2lF/EjNqH405HyCmQTGxEIW/jfrU=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>>  	return 0;
>> -error:
>> +
>> +report_failure:
>> +	PERR("Set packet size: set interface error");
>>  	return -EBUSY;
>>  }
> 
> Why change the label name?

I find the suggested variant a bi better.


> They are both equally uninformative.

Which identifier would you find appropriate there?

Regards,
Markus