Re: [PATCH v2 2/5] x86: ia32_signal: introduce COPY_SEG_STRICT

Ingo Molnar
2008-11-18T15:56:42Z

* Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:

> H. Peter Anvin wrote:
> > Hiroshi Shimamoto wrote:
> >> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> >>
> >> Impact: cleanup
> >>
> >> Introduce COPY_SEG_STRICT for ia32_restore_sigcontext().
> >>
> >
> > I don't like the name _STRICT() for this; if anything it seems to have
> > quite the opposite meaning. I would suggest COPY_SEG_USER() or even
> > COPY_SEG_CPL3().
>
> Sounds nice.
> I haven't thought about the name. I could not catch wrong meaning from
> _STRICT. My English skill isn't good.

i have changed it to COPY_SEG_CPL3() - no need to resend. Here are the
patches i've picked up into tip/x86/signal:

6497760: x86: ia32_signal: change order of storing in setup_sigcontext()
047ce93: x86: ia32_signal: remove using temporary variable
8c6e5ce: x86: ia32_signal: cleanup macro RELOAD_SEG
d71a68d: x86: ia32_signal: introduce COPY_SEG_CPL3
b78a5b5: x86: ia32_signal: cleanup macro COPY

thanks!

Ingo