From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Glauber Costa <glommer@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] always assign userspace_addr
Date: Thu, 20 Nov 2008 13:01:21 +0200 [thread overview]
Message-ID: <49254381.1050408@redhat.com> (raw)
In-Reply-To: <49246014.5000001@codemonkey.ws>
Anthony Liguori wrote:
>
> That's not how I read the code. I see:
>
>>
>> static void kvm_free_physmem_slot(struct kvm_memory_slot *free,
>> struct kvm_memory_slot *dont)
>> {
>> if (!dont || free->rmap != dont->rmap)
>> vfree(free->rmap);
>
> And it's called as kvm_free_physmem_slot(&old, &new);
>
> new is assigned to old to start out with so old.rmap will equal new.rmap.
>
Hm, if !npages we should just kvm_free_physmem_slot(&old, NULL).
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2008-11-20 11:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-18 3:04 [PATCH] always assign userspace_addr Glauber Costa
2008-11-19 15:55 ` Anthony Liguori
2008-11-19 18:43 ` Glauber Costa
2008-11-19 18:51 ` Anthony Liguori
2008-11-19 20:53 ` Glauber Costa
2008-11-19 20:59 ` Anthony Liguori
2008-11-20 11:01 ` Avi Kivity [this message]
2008-11-20 11:02 ` Avi Kivity
2008-11-21 18:11 ` Glauber Costa
2008-11-24 13:08 ` Glauber Costa
2008-11-25 14:04 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49254381.1050408@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox