From: Naohiro Ooiwa <nooiwa@miraclelinux.com>
To: broonie@opensource.wolfsonmicro.com
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] mfd: Fix define values of CS1_HIB_MODE.
Date: Thu, 20 Nov 2008 20:24:35 +0900 [thread overview]
Message-ID: <492548F3.6090307@miraclelinux.com> (raw)
Hi Mark,
I found a little mistake.
The define values are wrong.
It is written in the WM8350 DATA SHEET Rev 3.4 P285 that
CS1_HIB_MODE(bit 12) is disable at "1".
The following is it.
<WM8350 DATA SHEET Rev 3.4 P285>
REGISTER |BIT| LABEL | DESCRIPTION
ADDRESS | | |
---------+---+------------+-------------
R172(ACh)| 12|CS1_HIB_MODE| 0=leave current sink as in Active
| | | 1=disable current shik in Hibemate
Could you please check the following patch ?
Regards,
Naohiro Ooiwa
Signed-off-by: Naohiro Ooiwa <nooiwa@miraclelinux.com>
---
include/linux/mfd/wm8350/pmic.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/mfd/wm8350/pmic.h b/include/linux/mfd/wm8350/pmic.h
index 656279a..078363b 100644
--- a/include/linux/mfd/wm8350/pmic.h
+++ b/include/linux/mfd/wm8350/pmic.h
@@ -83,8 +83,8 @@
#define WM8350_CS1_ISEL_SHIFT 0
/* Bit values for R172 (0xAC) */
-#define WM8350_CS1_HIB_MODE_DISABLE 0
-#define WM8350_CS1_HIB_MODE_LEAVE 1
+#define WM8350_CS1_HIB_MODE_DISABLE 1
+#define WM8350_CS1_HIB_MODE_LEAVE 0
#define WM8350_CS1_ISEL_220M 0x3F
--
1.5.4.1
next reply other threads:[~2008-11-20 11:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 11:24 Naohiro Ooiwa [this message]
2008-11-20 14:04 ` [PATCH] mfd: Fix define values of CS1_HIB_MODE Mark Brown
2009-04-28 2:45 ` Naohiro Ooiwa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492548F3.6090307@miraclelinux.com \
--to=nooiwa@miraclelinux.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox