From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756469AbYKTV2U (ORCPT ); Thu, 20 Nov 2008 16:28:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755561AbYKTV2G (ORCPT ); Thu, 20 Nov 2008 16:28:06 -0500 Received: from terminus.zytor.com ([198.137.202.10]:39538 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755468AbYKTV2F (ORCPT ); Thu, 20 Nov 2008 16:28:05 -0500 Message-ID: <4925D596.3010304@zytor.com> Date: Thu, 20 Nov 2008 13:24:38 -0800 From: "H. Peter Anvin" User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: Takashi Iwai CC: Arjan van de Ven , linux-kernel@vger.kernel.org, Luc Verhaegen , Egbert Eich Subject: Re: vm86 segfaults with NX bit References: <20081120085844.6f158e08@infradead.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Takashi Iwai wrote: >>>> >>> did the code that mapped this memory setup use PROT_EXEC ? >> A good question... >> Luc, Egbert, how does VESA driver handle it? > > Just looking through the vesa directory of xorg-server code, PROT_EXEC > is passed for all mappings, at least. > > Please correct me if I'm looking at a wrong place... > Please do an strace of the X server startup up to the point of the crash. I am betting that PROT_EXEC is missing from an mmap(), or that it needs an additional mprotect(). -hpa