Re: [PATCHSET] FUSE: extend FUSE to support more operations, take #2

[Tejun Heo <tj@kernel.org>]

Hello, Miklos.

Miklos Szeredi wrote:
> Hi Tejun,
> 
> On Thu, 20 Nov 2008, Tejun Heo wrote:
>> This patchset is the second take of extend-FUSE patchset.  Changes
>> from the last take[L] are...
> 
> I managed to review and apply this and the libfuse patches up to the
> ioctl support.  After swithing _IOC_READ with _IOC_WRITE in the kernel
> the example program actually worked :)

Did I get that wrong?  Looking at it again.... oops.  It's reverse
alright.  Thanks for catching it.

> I removed ->unrestricted_ioctl() and associated code because it really
> doesn't make any sense: the high level lib won't be used for CUSE
> stuff, otherwise unrestrited ioctls are not allowed (and the interface
> is rather horrible anyway).

Well, CUSE highlevel interface piggy backs on FUSE so it requires
unrestricted_ioctl() there for it and ossp does use it.

> The poll patches look OK at a first glance too, I'll review them
> tomorrow.

Alright, thanks.

-- 
tejun