From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1757118AbYKUXuK@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757118AbYKUXuK (ORCPT <rfc822;w@1wt.eu>);
	Fri, 21 Nov 2008 18:50:10 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753651AbYKUXt5
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 21 Nov 2008 18:49:57 -0500
Received: from mail3.caviumnetworks.com ([12.108.191.235]:17151 "EHLO
	mail3.caviumnetworks.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753568AbYKUXt5 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 21 Nov 2008 18:49:57 -0500
Message-ID: <492748DA.3030805@caviumnetworks.com>
Date: Fri, 21 Nov 2008 15:48:42 -0800
From: David Daney <ddaney@caviumnetworks.com>
User-Agent: Thunderbird 2.0.0.16 (X11/20080723)
MIME-Version: 1.0
To: Andrew Morton <akpm@linux-foundation.org>
CC: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, gcc@gcc.gnu.org
Subject: Re: [PATCH] MIPS: Make BUG() __noreturn.
References: <49260E4C.8080500@caviumnetworks.com> <20081121150023.032f7b5b.akpm@linux-foundation.org>
In-Reply-To: <20081121150023.032f7b5b.akpm@linux-foundation.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 21 Nov 2008 23:48:42.0736 (UTC) FILETIME=[AF72F700:01C94C33]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Andrew Morton wrote:
>
> 
> Yup, this change will fix some compile warnings which will never be
> fixed in any other way for mips.
> 
>> +static inline void __noreturn BUG(void)
>> +{
>> +	__asm__ __volatile__("break %0" : : "i" (BRK_BUG));
>> +	/* Fool GCC into thinking the function doesn't return. */
>> +	while (1)
>> +		;
>> +}
> 
> This kind of sucks, doesn't it?  It adds instructions into the kernel
> text, very frequently on fast paths.  Those instructions are never
> executed, and we're blowing away i-cache just to quash compiler
> warnings.
> 
> For example, this:
> 
> --- a/arch/x86/include/asm/bug.h~a
> +++ a/arch/x86/include/asm/bug.h
> @@ -22,14 +22,12 @@ do {								\
>  		     ".popsection"				\
>  		     : : "i" (__FILE__), "i" (__LINE__),	\
>  		     "i" (sizeof(struct bug_entry)));		\
> -	for (;;) ;						\
>  } while (0)
>  
>  #else
>  #define BUG()							\
>  do {								\
>  	asm volatile("ud2");					\
> -	for (;;) ;						\
>  } while (0)
>  #endif
>  
> _
> 
> reduces the size of i386 mm/vmalloc.o text by 56 bytes.
> 
> I wonder if there is any clever way in which we can do this without
> introducing additional runtime cost.

As I said in the other part of the thread, We are working on a GCC patch 
that adds a new built-in function '__builtin_noreturn()', that you could 
substitute for 'for(;;);' that emits no instructions in this case.

David Daney